Skip to content

Added support for Custom Protocol - #33

Merged
ArvindHarinder1 merged 1 commit into
AzureAD:masterfrom
rinslow:master
Sep 10, 2020
Merged

ArvindHarinder1 merged 1 commit into
AzureAD:masterfrom
rinslow:master

Conversation

@rinslow

@rinslow Dan (rinslow) commented Sep 3, 2020 •

Copy link
Copy Markdown
Contributor

Background

This pull request replaces all explicit instances of https with {{Protocol}}, to allow a choice between http and https when running the test-suite in different environments.

Signed-off-by: Dan Elkis <dan@monday.com>
@ghost

Deleted user (ghost) commented Sep 3, 2020 •

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@ArvindHarinder1

Copy link
Copy Markdown
Contributor

Thanks for the PR. Looks like an agreement needs to be signed for me to merge now. If you could sign off, I can go ahead and merge the PR. Please note that we don't support HTTP endpoints when integrating with Azure AD, but you could certainly use it to test locally.

@rinslow

Copy link
Copy Markdown
Contributor Author

Alright, signed :)

@ArvindHarinder1
ArvindHarinder1 merged commit ae181c1 into AzureAD:master Sep 10, 2020
Marcus Carvalho (marcusca10) added a commit that referenced this pull request Nov 10, 2020
* Fixed build warnings

* Add files via upload

* Multiple issues addressed. (#25)

1. When the group membership to be removed is inlined in the path, it is now removed correctly from the group.
2. Members already part of the group cannot be re-added to the group.
3. Patching of the extension attribute used to fail if the user was not created using the extension attribute. That has been fixed.
4. Sundry formatting changes and fixes.

* Get ResourceTypes test condition (#26)

* Get ResourceTypes test condition

* fix Post enterprise user test, user enterprise schema for department

Co-authored-by: Plamen Stoyanov <plamens@knowbe4.com>

* Update README.md

* Added support for Custom Protocol (#33)

Signed-off-by: Dan Elkis <dan@monday.com>

Co-authored-by: RyanE <v-ryeaki@microsoft.com>
Co-authored-by: ArvindHarinder1 <36525136+ArvindHarinder1@users.noreply.github.com>
Co-authored-by: Ankit K Chheda <ankitC@users.noreply.github.com>
Co-authored-by: plamenGo <plamen25@gmail.com>
Co-authored-by: Plamen Stoyanov <plamens@knowbe4.com>
Co-authored-by: Dan Elkis <speakupness@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ Proxy