Repository navigation
fix(release): expect -release.apk names for beta builds in verifier and notes - #812
Merged
Merged
Conversation
…nd notes The release workflow builds assembleStandardRelease and assembleOfflineRelease for every beta-* and v* tag, so beta APKs are named -release.apk. The verifier and the beta2 notes flavor table wrongly used -debug.apk for betas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Betas ship as
-release.apk, but the release verifier and the v4.3.3-beta2 notes table expected and listed-debug.apk.Motivation & Context
build-release-apk.ymlrunsassembleStandardRelease assembleOfflineReleasefor everybeta-*andv*tag, andapp/build.gradle.ktsnames APKs<n>-LeanType_<ver>-<flavor>-<buildType>.apk. The publishedbeta-433-2assets are1-LeanType_4.3.3-standard-release.apkand2-LeanType_4.3.3-offline-release.apk, while the notes table listed-debug.apk.Changes Made
tools/verify_release_sync.py: always expect-release.apkin the flavor table, remove the unusedis_betaflag.docs/releasenote/release_notes_v4.3.3-beta2.md: flavor table uses-release.apk.docs/scripts/generate_release_notes.pyalready matches by exact name with a flavor fallback, so it needs no change.Verification & Testing
python3 tools/verify_release_sync.py 4.3.3-beta2 4330passes./gradlew :app:assembleStandardDebug(no app code touched)Guidelines Checklist