Repository navigation
build: raise offline flavor minSdk from 21 to 23 - #818
Merged
Merged
Conversation
Android 6.0 is the supported minimum. This clears the ~295 offline-only lint errors that only apply below API 23 (vector paths, long log tags, View.setForeground, Paint.hasGlyph). Align defaultConfig and the README and FEATURES.md flavor tables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The
offlineflavor now requires Android 6.0 (SDK 23), the same asstandard.Motivation & Context
Android 6.0 is the supported minimum.
lintOfflineDebugreported about 295 errors that exist only because the flavor declaredminSdk = 21(267InvalidVectorPath, 19LongLogTag, 9NewApiforView.setForegroundandPaint.hasGlyph).lintStandardDebug, with the same sources at minSdk 23, reports none.Changes Made
app/build.gradle.kts: offline flavorminSdk21 to 23, anddefaultConfigaligned (both flavors override it).README.mdanddocs/FEATURES.md: Offline flavor minimum is now Android 6.0+ (SDK 23).Verification & Testing
lintOfflineDebug: 0 errors (was 295)assembleOfflineDebugbuildsUser impact
Devices on Android 5.0 and 5.1 can no longer install or update the offline flavor.
Guidelines Checklist