Skip to content

fix: voice strip over open toolbar, custom style paste and backspace, shorter voice toggle text - #820

Merged
LeanBitLab merged 3 commits into
mainfrom
fix/custom-styles-paste
Nov 15, 2026
Merged

LeanBitLab merged 3 commits into
mainfrom
fix/custom-styles-paste

Conversation

@LeanBitLab

@LeanBitLab LeanBitLab commented Nov 15, 2026 •

Copy link
Copy Markdown
Owner

Summary of Changes

Fixes found while testing the previous batch on a device.

Changes Made

  • Voice strip: SuggestionStripView.setToolbarVisibility only suppressed the toolbar for external suggestions when it was not manually opened, so with the toolbar open any strip update during voice (typing a recognized piece) put it back over the animation. It is now suppressed while isVoiceActive, and the pinned keys stay hidden during voice.
  • Backspace deleting all text: getFullEmojiAtEnd returned the whole text when everything before the cursor consisted of codepoints that might be emoji (circled letters, parenthesized letters, arrows, math symbols), so one backspace removed everything left of the cursor. The whole text is now kept only if it has emoji sequence parts (ZWJ, variation selector, skin tone, flag letters, keycap, tag characters).
  • Custom text styles: the parser ignores variation selectors and format characters added by pasting, and accepts a bare alphabet without Name: (named Custom N by line position). The dialog gets a Features Guide button (existing string) that opens FEATURES.md#46-custom-text-styles; docs updated.
  • Voice settings: the Transcribe while speaking description is now "Shorter wait for long dictations" (translations regenerated by the pre-commit hook).
  • Tests for the parser cases and for emoji detection with symbol runs.

Verification & Testing

  • CustomTextStylesTest and StringUtilsTest pass
  • Builds and installs on a device
  • Strip fix, backspace fix and Guide button: still to be confirmed on a device

Guidelines Checklist

  • This PR addresses a single focused concern. (Several small related fixes from one test session.)
  • Does not add unnecessary dependencies or binary blobs.
  • No em dashes used in comments, descriptions, or documentation.

…sible paste characters

The voice status was replaced by the toolbar whenever the strip updated
while the toolbar had been opened manually (typing a recognized piece
triggered it). Suppress the toolbar while voice status is shown and keep
the pinned keys hidden.

Custom text styles: skip variation selectors and format characters when
counting a pasted alphabet, since pasting often adds them (for example
after circled M) and made a valid line 63 characters long.
The old summary was a long explanation. Use a short one and let the
pre-commit hook regenerate the translations.
…alog guide button and name-less lines

getFullEmojiAtEnd returned the whole text when everything before the
cursor consisted of codepoints that might be emoji (circled letters,
arrows, math symbols), so one backspace removed it all. Only keep the whole
text if it has emoji sequence parts such as ZWJ, variation selector, skin
tone, flag letters, keycap or tag characters.

Custom text styles: accept a bare pasted alphabet without 'Name:' (named
Custom N by position), and replace nothing in the dialog layout but add a
Features Guide button that opens the documentation section.
@LeanBitLab LeanBitLab changed the title fix: keep voice status over a manually opened toolbar and ignore invisible paste characters fix: voice strip over open toolbar, custom style paste and backspace, shorter voice toggle text Nov 15, 2026
@LeanBitLab
LeanBitLab merged commit e6e4578 into main Nov 15, 2026
1 check passed
@LeanBitLab
LeanBitLab deleted the fix/custom-styles-paste branch November 15, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

⌂ Proxy