Repository navigation
fix: voice strip over open toolbar, custom style paste and backspace, shorter voice toggle text - #820
Merged
Merged
Conversation
…sible paste characters The voice status was replaced by the toolbar whenever the strip updated while the toolbar had been opened manually (typing a recognized piece triggered it). Suppress the toolbar while voice status is shown and keep the pinned keys hidden. Custom text styles: skip variation selectors and format characters when counting a pasted alphabet, since pasting often adds them (for example after circled M) and made a valid line 63 characters long.
The old summary was a long explanation. Use a short one and let the pre-commit hook regenerate the translations.
…alog guide button and name-less lines getFullEmojiAtEnd returned the whole text when everything before the cursor consisted of codepoints that might be emoji (circled letters, arrows, math symbols), so one backspace removed it all. Only keep the whole text if it has emoji sequence parts such as ZWJ, variation selector, skin tone, flag letters, keycap or tag characters. Custom text styles: accept a bare pasted alphabet without 'Name:' (named Custom N by position), and replace nothing in the dialog layout but add a Features Guide button that opens the documentation section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fixes found while testing the previous batch on a device.
Changes Made
SuggestionStripView.setToolbarVisibilityonly suppressed the toolbar for external suggestions when it was not manually opened, so with the toolbar open any strip update during voice (typing a recognized piece) put it back over the animation. It is now suppressed whileisVoiceActive, and the pinned keys stay hidden during voice.getFullEmojiAtEndreturned the whole text when everything before the cursor consisted of codepoints that might be emoji (circled letters, parenthesized letters, arrows, math symbols), so one backspace removed everything left of the cursor. The whole text is now kept only if it has emoji sequence parts (ZWJ, variation selector, skin tone, flag letters, keycap, tag characters).Name:(namedCustom Nby line position). The dialog gets a Features Guide button (existing string) that opensFEATURES.md#46-custom-text-styles; docs updated.Verification & Testing
CustomTextStylesTestandStringUtilsTestpassGuidelines Checklist