Skip to content

chore(res): remove redundant and stale translations - #836

Merged
LeanBitLab merged 2 commits into
mainfrom
chore/remove-stale-resources
Nov 15, 2026
Merged

LeanBitLab merged 2 commits into
mainfrom
chore/remove-stale-resources

Conversation

@LeanBitLab

Copy link
Copy Markdown
Owner

Summary

  • Remove 324 entries in `values-*/strings.xml` that are identical to the base value of strings the base file marks `translatable="false"` (Groq/Gemini/OpenAI endpoint URLs, aliases to system strings such as `@android:string/cut`). No runtime change.
  • Remove the stale `no_dictionary_message` translation in ur, ml and el. They still use the old one-argument text while the base string takes three arguments, so those locales fall back to the complete English message until retranslated (visible change for those three locales).

Deliberately not changed

  • The 16 translated copies that differ from the base (for example `cut` in ar, bn, eu, nl, pl) are real localized overrides, deleting them would change displayed text.
  • The 33 `UnusedResources` strings: several are resolved by name at runtime (`layout_` via `getIdentifier` in `SubtypeLocaleUtils.kt`, `custom_ai_`, `spoken_*`) and lint cannot see that, so they need a separate audit.

Verification

  • Diff of the first commit is 324 deletions, 0 additions; no base `values/strings.xml` is touched, so the i18n pre-commit hook does not run.
  • `./gradlew :app:assembleStandardDebug` passes
  • `lintStandardDebug`: 0 errors, Untranslatable 340 -> 16, StringFormatCount 3 -> 0

…e base strings

324 entries in values-*/strings.xml repeat the value of strings the base file marks
translatable=false (Groq/Gemini/OpenAI endpoint URLs and aliases to system strings).
Removing them changes nothing at runtime. The 16 copies that differ from the base are kept.
The translations still use the old one-argument text, the base string now takes three
arguments (download link, language, direct link). Those locales fall back to the complete
English message until they are retranslated.
@LeanBitLab
LeanBitLab merged commit 0cbbf70 into main Nov 15, 2026
@LeanBitLab
LeanBitLab deleted the chore/remove-stale-resources branch November 15, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

⌂ Proxy