Skip to content

chore(lint): disable PluralsCandidate - #841

Merged
LeanBitLab merged 1 commit into
mainfrom
chore/lint-disable-plurals-candidate
Nov 15, 2026
Merged

LeanBitLab merged 1 commit into
mainfrom
chore/lint-disable-plurals-candidate

Conversation

@LeanBitLab

Copy link
Copy Markdown
Owner

Summary

Disable the PluralsCandidate lint check in the lint block of app/build.gradle.kts.

Why not convert the 11 flagged strings to <plurals>:

  • The project has no <plurals> anywhere and no code uses getQuantityString / pluralStringResource; all 11 call sites use getString / stringResource.
  • tools/autotranslate_settings.py (the pre-commit translation hook) only processes <string> elements, so plural forms would have to be written by hand for each of the 29 translated locales.
  • Languages such as ru, pl, ar and he need extra quantity forms, and a locale missing one fails lint with MissingQuantity (an error, abortOnError is on).
  • Several of the 11 are not real plural cases: "%d selected", "Custom (%d tokens)", "Add after typing %d times", and a sentence with three numbers.

The few real English "1 items" style cases are left as they are.

Verification

lintStandardDebug: 0 errors, 181 -> 170 warnings, PluralsCandidate 11 -> 0. Gradle config only, so CI does not trigger (path filter is app/src/main/java**).

The translation tooling only handles <string> elements and the project has no
<plurals>, which would also need per-locale quantity forms for 29 locales.
@LeanBitLab
LeanBitLab merged commit 9aee791 into main Nov 15, 2026
@LeanBitLab
LeanBitLab deleted the chore/lint-disable-plurals-candidate branch November 15, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

⌂ Proxy