Repository navigation
chore(lint): disable PluralsCandidate - #841
Merged
Merged
Conversation
The translation tooling only handles <string> elements and the project has no <plurals>, which would also need per-locale quantity forms for 29 locales.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disable the
PluralsCandidatelint check in thelintblock ofapp/build.gradle.kts.Why not convert the 11 flagged strings to
<plurals>:<plurals>anywhere and no code usesgetQuantityString/pluralStringResource; all 11 call sites usegetString/stringResource.tools/autotranslate_settings.py(the pre-commit translation hook) only processes<string>elements, so plural forms would have to be written by hand for each of the 29 translated locales.MissingQuantity(an error,abortOnErroris on).The few real English "1 items" style cases are left as they are.
Verification
lintStandardDebug: 0 errors, 181 -> 170 warnings,PluralsCandidate11 -> 0. Gradle config only, so CI does not trigger (path filter isapp/src/main/java**).