Repository navigation
style(toolbar): redraw the text edit key icon with clearer arrows - #847
Merged
Merged
Conversation
The two arrow triangles were 3.5 units wide and 0.5 units from the I-beam serifs, so the icon looked crowded. Use a slimmer I-beam and larger arrows at the edges with a clear gap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The text edit toolbar key icon was crowded: the two arrow triangles were 3.5 units wide and sat 0.5 units from the I-beam serifs, so they merged with the beam.
Redrawn with a slimmer I-beam and larger arrows (8 units tall) pushed to the edges, with a 2.5 unit gap on each side. The same drawable is used by all icon styles and by the Text Expander screen.
Checked on device (debug build).