Skip to content

fix(clipboard): keep action pill icons visible on mid-tone themes - #848

Merged
LeanBitLab merged 1 commit into
mainfrom
fix/clipboard-action-pill-contrast
Nov 16, 2026
Merged

LeanBitLab merged 1 commit into
mainfrom
fix/clipboard-action-pill-contrast

Conversation

@LeanBitLab

Copy link
Copy Markdown
Owner

Problem

The clipboard long-press action pill (pin / edit / delete / select) showed as all white on some themes, hiding the icons.

Cause

The pill was filled white unless isDarkColor was true for the main or card background. That check only passes for near-black colors (brightness < 50), so a mid-tone theme with light KEY_ICON got white icons on a white pill.

Fix

Use the toolbar background fill whenever the icon color is light (luminance > 0.5), in addition to the existing dark-theme case.

Testing

  • ./gradlew :app:compileStandardDebugKotlin passes
  • Not yet checked on a device with a mid-tone theme

The pill was filled white unless the theme background was near-black
(isDarkColor threshold), while its icons use KEY_ICON. A mid-tone theme
with light icons got white icons on a white pill. Use the toolbar
background whenever the icon color is light.
@LeanBitLab
LeanBitLab merged commit cba01aa into main Nov 16, 2026
1 check passed
@LeanBitLab
LeanBitLab deleted the fix/clipboard-action-pill-contrast branch November 16, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

⌂ Proxy