Repository navigation
fix(clipboard): keep action pill icons visible on mid-tone themes - #848
Merged
Merged
Conversation
The pill was filled white unless the theme background was near-black (isDarkColor threshold), while its icons use KEY_ICON. A mid-tone theme with light icons got white icons on a white pill. Use the toolbar background whenever the icon color is light.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The clipboard long-press action pill (pin / edit / delete / select) showed as all white on some themes, hiding the icons.
Cause
The pill was filled white unless
isDarkColorwas true for the main or card background. That check only passes for near-black colors (brightness < 50), so a mid-tone theme with lightKEY_ICONgot white icons on a white pill.Fix
Use the toolbar background fill whenever the icon color is light (luminance > 0.5), in addition to the existing dark-theme case.
Testing
./gradlew :app:compileStandardDebugKotlinpasses