Skip to content

fix: one-handed mode, CJK plugin, emoji clipping and floating toolbar - #862

Merged
LeanBitLab merged 4 commits into
mainfrom
fix/one-handed-cjk-floating
Nov 18, 2026
Merged

LeanBitLab merged 4 commits into
mainfrom
fix/one-handed-cjk-floating

Conversation

@LeanBitLab

Copy link
Copy Markdown
Owner

Summary of Changes

Fixes for the 4.3.4 reports: CJK plugin state on physical keyboards, one-handed mode stability and smoothness, clipped emojis, and the tiny floating toolbar.

Motivation & Context

Fixes #860
Refs #842 (needs confirmation from the reporter on the beta)

Changes Made

  • CJK ([Bug]: CJK Japanese input resets to Chinese after switching apps (physical keyboard) #842): do not release the plugin engine on every app switch (UI_HIDDEN) or while an input session is active; reuse the class loader per native lib dir so the native library is not reopened by a new loader; synchronize load, release, import and remove; record the import timestamp.
  • One-handed mode: controls stay above the navigation bar, side re-syncs when the mode is already enabled, controls come back after touchpad mode, resize previews by scaling the view and rebuilds once on release (was a rebuild per move, ~100 ms each), keyboard slides when switching sides, controls styled as square toolbar keys.
  • Emoji: tall emojis scaled to 90% of the key height and centered, so the partial redraw no longer clips them.
  • Floating toolbar ([Bug]: 4.3.4 update makes arrow keys in pinned toolbar very small #860): strip height scales from the docked height (24dp min, docked height max) instead of the key height, which shrank with extra rows.

Verification & Testing

  • Build compiles cleanly via ./gradlew :app:assembleStandardDebug
  • Tested on device / emulator (one-handed mode and floating toolbar)
  • Verified zero typing latency impact on the input path
  • Checked for regressions across light and dark themes

Not tested locally: CJK physical keyboard flow and the emoji clipping (no repro here), left for the beta reporters.

Guidelines Checklist

  • This PR addresses a single focused concern. (bundles four small 4.3.4 regression fixes for one beta)
  • Follows coding guidelines in CONTRIBUTING.md.
  • Does not add unnecessary dependencies or binary blobs.
  • No em dashes used in comments, descriptions, or documentation.

UI_HIDDEN trim fires on every app switch, and with a physical keyboard the input view can be hidden while typing, so the engine was released and reloaded in a new class loader, failing to reopen the native library and falling back to Chinese. Release only when no input session is active, reuse the loader per native lib dir, synchronize load/release and record the import timestamp. Refs #842
Keep the controls above the navigation bar, re-sync the side when the mode is already on, restore the controls after touchpad mode, preview resizing by scaling the view with a single rebuild on release, slide the keyboard when switching sides and style the controls as square toolbar keys.
Scale emoji labels down to 90% of the key height and center them vertically, so they are no longer clipped by the partial redraw of the row below.
The strip height was derived from the key height, so layouts with more rows (number row, PC layouts) got a tiny toolbar. Scale the docked height instead, between 24dp and the docked height. Fixes #860
@LeanBitLab
LeanBitLab merged commit 511ecb2 into main Nov 18, 2026
1 check passed
@LeanBitLab
LeanBitLab deleted the fix/one-handed-cjk-floating branch November 18, 2026 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: 4.3.4 update makes arrow keys in pinned toolbar very small

1 participant

⌂ Proxy