Repository navigation
fix: one-handed mode, CJK plugin, emoji clipping and floating toolbar - #862
Merged
Merged
Conversation
UI_HIDDEN trim fires on every app switch, and with a physical keyboard the input view can be hidden while typing, so the engine was released and reloaded in a new class loader, failing to reopen the native library and falling back to Chinese. Release only when no input session is active, reuse the loader per native lib dir, synchronize load/release and record the import timestamp. Refs #842
Keep the controls above the navigation bar, re-sync the side when the mode is already on, restore the controls after touchpad mode, preview resizing by scaling the view with a single rebuild on release, slide the keyboard when switching sides and style the controls as square toolbar keys.
Scale emoji labels down to 90% of the key height and center them vertically, so they are no longer clipped by the partial redraw of the row below.
The strip height was derived from the key height, so layouts with more rows (number row, PC layouts) got a tiny toolbar. Scale the docked height instead, between 24dp and the docked height. Fixes #860
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fixes for the 4.3.4 reports: CJK plugin state on physical keyboards, one-handed mode stability and smoothness, clipped emojis, and the tiny floating toolbar.
Motivation & Context
Fixes #860
Refs #842 (needs confirmation from the reporter on the beta)
Changes Made
Verification & Testing
./gradlew :app:assembleStandardDebugNot tested locally: CJK physical keyboard flow and the emoji clipping (no repro here), left for the beta reporters.
Guidelines Checklist