Skip to content

Refactor the readme file - #81

Merged
pomadchin merged 7 commits into
PDAL:mainfrom
WhiteSte:patch-2
Jan 24, 2024
Merged

pomadchin merged 7 commits into
PDAL:mainfrom
WhiteSte:patch-2

Conversation

@WhiteSte

Copy link
Copy Markdown
Contributor

Macos arm users who want to use pdal-java cannot use directly the maven published jars because they are missing arm native libs. Added a guide for a self build

@WhiteSte

Copy link
Copy Markdown
Contributor Author

I've refactored completely the structure of the readme file in order to be more readable

@WhiteSte WhiteSte changed the title Add a new readme section Refactor the readme file Jan 20, 2024
@pomadchin pomadchin added the docs label Jan 21, 2024

@pomadchin pomadchin left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 🚀, I left a couple of comments though to response / address.

(comments can be hidden under cut, easy to miss them)

image

Comment thread README.md Resolved
Comment thread README.md Resolved
Comment thread README.md Resolved
Comment thread README.md Resolved
Comment thread README.md Resolved
Comment thread README.md Resolved
Comment thread README.md Resolved
Comment thread README.md Resolved
Comment thread README.md Resolved
Comment thread README.md Resolved
Comment thread README.md Resolved
@WhiteSte

Copy link
Copy Markdown
Contributor Author

I think i solved almost all of them except for one

Comment thread README.md Resolved
Comment thread README.md Resolved
Comment thread README.md Outdated
Comment on lines +47 to +48
"io.pdal" %% "pdal-scala" % "<latest version>", // scala core library
"io.pdal" % "pdal-native" % "<latest version>" // jni bindings
"io.pdal" %% "pdal-scala" % "<latest version>", // scala core library
"io.pdal" % "pdal-native" % "<latest version>" // jni bindings

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also affects the preview.

Comment thread README.md Resolved
Comment thread README.md Resolved
Comment thread README.md Resolved
Comment thread README.md Resolved
Comment thread README.md Resolved
Comment thread README.md Resolved
Comment thread README.md Resolved
Comment thread README.md Resolved
@pomadchin

Copy link
Copy Markdown
Collaborator

Thx for working on the docs to make them more readable; really appreciate it! Sorry that I'm leaving up a bunch of comments every time.

@WhiteSte

Copy link
Copy Markdown
Contributor Author

Thx for working on the docs to make them more readable; really appreciate it! Sorry that I'm leaving up a bunch of comments every time.

Do not worry! I will take care next hours or tomorrow!

Comment thread README.md Resolved

@pomadchin pomadchin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for making this hard work! Only two more comments to go!

@WhiteSte

Copy link
Copy Markdown
Contributor Author

Done, hope i didn't missed any comment

@pomadchin pomadchin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Thanks!

@pomadchin
pomadchin merged commit 25dd25b into PDAL:main Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ Proxy