Repository navigation
Merged
Conversation
| import angular from 'angular'; | ||
| import * as ws from 'ws'; | ||
|
|
||
| var Socket = (ws.Client || ws.client || ws); |
Author
There was a problem hiding this comment.
This check previously existed inside of a function call. It is preferable to do these kinds of checks outside of any particular function. Also, the try/catch block that silently swallowed errors was a bit of a code smell to me. UMD fixes the problem (I think) you were trying to solve via that mechanism.
Author
There was a problem hiding this comment.
Tests fail when this is removed. So I put it back in.
added 3 commits
April 20, 2016 14:18
This recommits d92fe86 Signed-off-by: Will Soto <will.soto@fanduel.com>
Signed-off-by: Will Soto <will.soto@fanduel.com>
Owner
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Clean up packaging. Several commits have been lost due to the confusing way this package is structured.
Changes
This PR adds Babel primarily to get UMD bundling. This enables the module to be consumed by any environment transparently falling back to using the
windowif needed. This removes the shell scripts in favor ofnpm scriptsas well.I have also recommitted d92fe86 since it was blown away by the old build process.
SemVer Changes
This will require a major version bump (to 2.0) because of the breaking changes
Closes #74