Repository navigation
Fixes for failing tests and a few additional, related tests - #228
Open
Bryan Cuneo (BryanCuneo) wants to merge 5 commits into
Open
Bryan Cuneo (BryanCuneo) wants to merge 5 commits into
Bryan Cuneo (BryanCuneo) wants to merge 5 commits into
Conversation
…e.other.constant.powershell'
Author
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Update scopes for
$homeand$errorand update tests to match. Fixes #227PR Context
$error$errorwas listed under built-in constants inPowerShellSyntax.tmLanguage. Automatic, read-only variables seems like a more fitting scope. Insyntax_test_TheBigTestFile.ps1, it was being tested for the scopesupport.constant.variable.powershellwhich, as far as I can tell, doesn't actually exist in the grammar. I've updated it tosupport.variable.automatic.powershellto match the updated grammar.$home$home, while appropriately being listed as a built-in constant, was also being tested for scopesupport.constant.variable.powershellwhich, again, doesn't seem to exist in the grammar. I updated the test to match the grammar:variable.other.constant.powershellOther automatic constants
The other automatic constants in scope
variable.other.constant.powershelldidn't seem to be tested at all, so I added tests for them..gitignoreandpackage-lock.jsonA little bit of housekeeping. I'm working in VS Code and needed to add some project-specific settings so I created them in
.vscode/settings.jsonand ignored it. I'm also building and running the tests with the latest NodeJS LTS release, v26.13.0. This automatically updates the lock file formatting so I've included that update here.