Skip to content

Fixes for failing tests and a few additional, related tests - #228

Open
Bryan Cuneo (BryanCuneo) wants to merge 5 commits into
PowerShell:mainfrom
BryanCuneo:test-error-fixes
Open

Bryan Cuneo (BryanCuneo) wants to merge 5 commits into
PowerShell:mainfrom
BryanCuneo:test-error-fixes

Conversation

@BryanCuneo

Copy link
Copy Markdown

PR Summary

Update scopes for $home and $error and update tests to match. Fixes #227

PR Context

$error

$error was listed under built-in constants in PowerShellSyntax.tmLanguage . Automatic, read-only variables seems like a more fitting scope. In syntax_test_TheBigTestFile.ps1, it was being tested for the scope support.constant.variable.powershell which, as far as I can tell, doesn't actually exist in the grammar. I've updated it to support.variable.automatic.powershell to match the updated grammar.

$home

$home, while appropriately being listed as a built-in constant, was also being tested for scope support.constant.variable.powershell which, again, doesn't seem to exist in the grammar. I updated the test to match the grammar: variable.other.constant.powershell

Other automatic constants

The other automatic constants in scope variable.other.constant.powershell didn't seem to be tested at all, so I added tests for them.

.gitignore and package-lock.json

A little bit of housekeeping. I'm working in VS Code and needed to add some project-specific settings so I created them in .vscode/settings.json and ignored it. I'm also building and running the tests with the latest NodeJS LTS release, v26.13.0. This automatically updates the lock file formatting so I've included that update here.

@BryanCuneo

Copy link
Copy Markdown
Author

Bryan Cuneo (Bryan Cuneo (@BryanCuneo)) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests fail on main branch

1 participant

⌂ Proxy