Repository navigation
feat(results): show two or more result sets as tabs above the grid - #3924
Merged
Merged
Conversation
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Summary
NSSegmentedControl, with the tabs role on macOS 27. Measured on 27.0.1: SwiftUI's segmented and.tabspickers drop a segment's image, so the pin glyph on a pinned tab needs AppKit.setMenu(_:forSegment:)ignores right-click, there is no segment hit test), so there is no per-tab context menu.usersandusers (2). The pull-down title is a position,2 of 4, and the comparison titles use the result names.ResultSetMenuModelTests.titleCountsResultschanges fromResult 2 of 4to2 of 4on purpose./fixstill find it.Test plan
ResultSetTabBarLayoutTests(tabs, fallback, more than six, pin and selection, width, 150pt pane),ScriptErrorResultTests(a failed script through the coordinator), close/close others/gate/menu-flag cases inResultPinningTests, placement and error-precedence cases inQueryResultPresentationTests,ResultSetPolicyTestsover 2 to 8 results, emoji truncation inResultSetMenuModelTestsandStatementAnchorTests.QueryRunUITestsclicks a result tab and checks the switch.Fixes #3869