Skip to content

Change license.file to license-files + SPDX-compliance - #528

Merged
matt-graham merged 5 commits into
mainfrom
paddyroddy-patch-1
Apr 3, 2025
Merged

matt-graham merged 5 commits into
mainfrom
paddyroddy-patch-1

Conversation

@paddyroddy

@paddyroddy paddyroddy commented Apr 2, 2025 •

Copy link
Copy Markdown
Member

I encountered this issue when making a release astro-informatics/sleplet#451. Also, make BSD-3 SPDX-compliant.

I encountered this issue when making a release astro-informatics/sleplet#451
@paddyroddy paddyroddy added bug Something isn't working p1-critical labels Apr 2, 2025
@paddyroddy paddyroddy self-assigned this Apr 2, 2025

@matt-graham matt-graham left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

In case helpful to anyone understanding why this change is required, relevant part of Python Packaging User Guide documentation says that

As per PEP 639 licenses should be declared with two fields:

A previous PEP had specified license to be a table with a file or a text key, this format is now deprecated.

@matt-graham matt-graham left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually reading the above linked documentation a bit more carefully I think we want to specify both license and license-files fields?

paddyroddy and others added 3 commits April 2, 2025 16:01
Co-authored-by: Matt Graham <matthew.m.graham@gmail.com>
Co-authored-by: Matt Graham <matthew.m.graham@gmail.com>
@paddyroddy

Copy link
Copy Markdown
Member Author

https://stackoverflow.com is currently down

@paddyroddy

Copy link
Copy Markdown
Member Author

Actually reading the above linked documentation a bit more carefully I think we want to specify both license and license-files fields?

I glanced over it initially, but yeah I think you are right, it does want both. It didn't error with just one, but did with the use of the old license.file.

@paddyroddy
paddyroddy requested a review from matt-graham April 2, 2025 15:09
@paddyroddy paddyroddy changed the title Change license.file to license-files Change license.file to license-files + SPDX-compliance Apr 2, 2025

@matt-graham matt-graham left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating, looks all good to me.

@matt-graham
matt-graham merged commit b80f50b into main Apr 3, 2025
@matt-graham
matt-graham deleted the paddyroddy-patch-1 branch April 3, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ Proxy