Repository navigation
Security/node2shell - #156
Merged
Merged
Conversation
The repository's default workflow token has write access, so every job, including the ones that only build and test, could push code, create releases or edit issues. If a step or a third party action in such a job is compromised, it gets the same access. Each workflow without a permissions block now starts with permissions: contents: read. Jobs that need to write get their own block: - create-release.yml: contents: write (creates the tag and GitHub release) - prep-release.yml: contents: write, pull-requests: write (peter-evans/create-pull-request pushes a branch and opens a PR) Changed: create-release.yml, linux.yml, manual-start.yml, prep-release.yml
Create Release runs on every push to main that touches package.json. When package.json does not hold the next version, NEW_VERSION stays empty and the GitHub Release step fails. And when a push run and a manual run overlap, both release the same version and the release notes end up twice (seen in webperf_core 2026.10.2). - the release and publish steps now run only when NEW_VERSION is set, and a step says why the rest was skipped - runs are queued (concurrency group, no cancel), so a second run sees the new tag, computes the next version and publishes nothing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.