Skip to content

[BUG] Thumbnail can be selected outside of trim #630

Open

Description

@Ludotrico

When trimming a video and then selecting a thumbnail, the thumbnail chooser view is unaware of the trim and allows you to choose a frame outside of the trim.

This is not good @heitara @NikKovIos

Activity

  1. heitara commented on Jan 25, 2021

    @heitara
    Contributor

    @Ludotrico could you record a short video that illustrates this bug?

  2. Ludotrico commented on Jan 25, 2021

    @Ludotrico
    Author

    https://youtu.be/f7JQYdOIC5g Did you get a chance to look at this? @heitara @NikKovIos @s4cha

  3. Ludotrico commented on Mar 17, 2021

    @Ludotrico
    Author

    It has been a few months, any signs of life? @heitara @NikKovIos @s4cha

  4. added
    BugThis is clearly a bug and will be fixed in priority
    on Mar 17, 2021
  5. NikKovIos commented on Mar 18, 2021

    @NikKovIos
    Collaborator

    Unfortunately this functional depends on https://github.com/HHK1/PryntTrimmerView/issues pod.

  6. NikKovIos commented on Mar 19, 2021

    @NikKovIos
    Collaborator

    We with @s4cha decided to insert PryntTrimmerView code into the project and remove the cocoapods dependence for this. It will help to give the possibility to fix the bug.

  7. Ludotrico commented on Mar 19, 2021

    @Ludotrico
    Author

    That's a good start, thank you @NikKovIos

  8. gupta1111-eng commented on Jun 2, 2021

    @gupta1111-eng

    Hi @NikKovIos Any update on this?

  9. NikKovIos commented on Jun 4, 2021

    @NikKovIos
    Collaborator

    I've been granted an access to push and publish updates for TrimmerView but don't have time to fix that. However, you can create an issue in https://github.com/HHK1/PryntTrimmerView/issues to make the changes faster.

  10. NikKovIos commented on Sep 21, 2025

    @NikKovIos
    Collaborator

    @Ludotrico @gupta1111-eng @heitara
    Please make a PR with fix into https://github.com/HHK1/PryntTrimmerView/pulls, I would merge and make a release with fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugThis is clearly a bug and will be fixed in priority

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      ⌂ Proxy