Repository navigation
chore: read the codespell settings from pyproject.toml - #4213
Open
oresttokovenko wants to merge 1 commit into
Open
oresttokovenko wants to merge 1 commit into
oresttokovenko wants to merge 1 commit into
Conversation
Collaborator
|
CI failures will be fixed by #4216 |
Fokko
approved these changes
Oct 31, 2026
Fokko
left a comment
Contributor
There was a problem hiding this comment.
Ohh, this is nice @oresttokovenko Less is more
Fokko
enabled auto-merge
October 31, 2026 22:25
codespell reads [tool.codespell], so the separate .codespellrc file is one less thing at the root of the repository.
auto-merge was automatically disabled
October 31, 2026 22:31
Head branch was pushed to by a user without write access
oresttokovenko
force-pushed
the
codespell-config-in-pyproject
branch
from
October 31, 2026 22:31
bc00c24 to
ee4c36d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Move the codespell settings from
.codespellrcinto[tool.codespell]inpyproject.toml.Why
Every other tool in this repository is configured in
pyproject.toml..codespellrcholds a single line, and the file only exists because codespell had nowhere else to go when it was added.Tests
prek run codespell --all-filespasses on a file containingBoundIn NotIn fo oT, the words on the ignore list, and fails onteh, so the pass is not vacuous. The same file fails whencodespellruns from a directory where the config is not visible, which shows the section inpyproject.tomlis what makes it pass.