Repository navigation
Conversation
There was a problem hiding this comment.
I would change the name of the file to SpaceCounter.py, to match with the file names of the other problems in the github. Drop the word solution as it is redundant because the file is in the solutions directory already. Change the formatting to match black and flake8. Add a comment at the top detailing the specifications of the problem (just copy paste it from notion), and add this to the template code as well. Also I would add a boolean variable run set to true, and set it to false when the quit event is triggered (this is to match semantics taught in the python games course). Finally, move the pygame.quit() to the outside of the loop as it is not triggered because you break out of the loop too early.
hpanchal092
left a comment
There was a problem hiding this comment.
add pygame.quit() to the last line
| display_counter += 1 | ||
|
|
||
| # Updates the data | ||
| pygame.display.update() |
There was a problem hiding this comment.
add pygame.quit() to the last line
There was a problem hiding this comment.
everything else looks good
|
Closing because the PR was made from a fork which causes checks to fail, see #161 for new PR |
No description provided.