Repository navigation
I/O exception and does not commit #318
Description
Description
Prints an I/O exception and continues. At the end doesn't commit to git but only prints the commit text
Steps to reproduce
Type cz commit or cz c and continue
Current behavior
→ Test_Mattutini_PICO: [master ≡ +0 ~2 -0 !]› cz c
? Select the type of change you are committing fix: A bug fix. Correlates with PATCH in SemVer
? What is the scope of this change? (class or file name): (press [enter] to skip)
C2C
Unhandled exception in event loop:
File "c:\python38\lib\asyncio\proactor_events.py", line 768, in _loop_self_reading
f.result() # may raise
File "c:\python38\lib\asyncio\windows_events.py", line 808, in _poll
value = callback(transferred, key, ov)
File "c:\python38\lib\asyncio\windows_events.py", line 457, in finish_recv
raise ConnectionResetError(*exc.args)
Exception [WinError 995] Operazione di I/O terminata a causa dell'uscita dal thread oppure della richiesta di un'applicazione
Press ENTER to continue...
? Write a short and imperative summary of the code changes: (lower case and no period)Desired behavior
Environment
- commitizen version: 2.11.1
- python version: Python 3.8.3
- operating system: Windows
Activity
woile commentedon Dec 21, 2020
I think it's related to prompt-toolkit/python-prompt-toolkit#1023
And happens because of windows and because of our dependency with
prompt-toolkit.Seems like a python bug: https://bugs.python.org/issue39010
Bogay commentedon Sep 26, 2021
According to this comment, It seems that this bug is fixed at python? But in a newer version (e.g. 3.8.7)
prompt-toolkit/python-prompt-toolkit#1023 (comment)
At least it works on my windows (I use python 3.8.7 instead of 3.8.3)
Lee-W commentedon Sep 26, 2021
@LukeSavefrogs in this case, I don't think we'll be able to fix the older version on our side. I'll close this one for now. Feel free to reopen it if you think more discussion is needed
@Bogay Could you please add a FAQ page and add it as part of the documentation so that others will know they need to upgrade their python version for this to work? Thanks!
Bogay commentedon Sep 26, 2021
@Lee-W I found there exist 2 FAQ section: one in README and one in documentation, and the documentation one covers README one. Should I also removed the README's FAQ secion? (or leave the documentation link there)
README: https://github.com/commitizen-tools/commitizen#faq
doc: https://commitizen-tools.github.io/commitizen/faq/
Lee-W commentedon Sep 26, 2021
Let's move all the FAQ to https://commitizen-tools.github.io/commitizen/faq/ and add a link to README
Bogay commentedon Nov 18, 2021
@Lee-W As #431 merged, maybe this issue can be closed?
Lee-W commentedon Nov 19, 2021
Sounds good! Let's me close it