Skip to content

chore(hooks): add ggshield secret scan to husky hooks and drop secrets-scan workflow - #267

Merged
Harshi-Shah-CS merged 3 commits into
developmentfrom
CL-0000_ggshield-hooks
Oct 29, 2026
Merged

Harshi-Shah-CS merged 3 commits into
developmentfrom
CL-0000_ggshield-hooks

Conversation

@Harshi-Shah-CS

Copy link
Copy Markdown
Contributor

What

Requested by Security (Aravind Kumar):

  • Remove .github/workflows/secrets-scan.yml. GitGuardian's remote GitHub check already scans every PR, and GitGuardian Security Checks is a required status check on development and main. Its .talismanrc entry goes too.
  • Add the standard ggshield block (Secrets Scanning | Gitguardian | CLI (ggshield) - Setup, §6.1) to the top of .husky/pre-commit and .husky/pre-push. The existing Talisman, trufflehog, Snyk and test steps stay below it, unchanged. The scan is skipped in CI ($CI set).

Two changes from the standard block:

  • A missing ggshield warns, it doesn't block. launch-cli is a public repo, and the page says a missing install "blocks on internal repos, warns on public repos". If ggshield is installed and finds a secret, the commit or push is still blocked.
  • pre-push reads the pushed refs once and passes them to both ggshield and secrets-scan.sh. Both read the refs from stdin. Without this, ggshield would take them all, and secrets-scan.sh would see empty stdin and exit 0 without running Talisman/trufflehog.

.talismanrc gets checksum entries for both hook files: Talisman flags the ggshield warning line, which has the setup URL in it.

Tests

  • Ran the pre-push hook against a stand-in ggshield: both scans got every ref; with ggshield missing it warns and carries on; with CI=1 it skips ggshield; when ggshield fails it exits 1.
  • The commit and this push ran through the updated hooks (prepack, lint-staged, Talisman, trufflehog, Snyk, npm run test).

#claude_code#
🤖 Generated with Claude Code

Harshi-Shah-CS and others added 3 commits October 29, 2026 16:16
Update deployment logs query to V2, Add rollback plan-not-available message and Upgrade cli-utilities with Snyk fixes
Update deployment logs query to V2, Add rollback plan-not-available message and Upgrade cli-utilities with Snyk fixes
…s-scan workflow (+Claude)

GitGuardian's remote GitHub check already scans every PR, so the
secrets-scan.yml workflow is redundant; remove it and its .talismanrc entry.

Add Contentstack Security's standard ggshield block to the top of
.husky/pre-commit and .husky/pre-push. launch-cli is public, so a missing
ggshield warns instead of blocking; a secret ggshield finds still blocks.
pre-push reads the pushed refs once and pipes them to both ggshield and
secrets-scan.sh, since each reads stdin and the second would otherwise get
nothing and skip the Talisman/trufflehog scan. Both hook files get a
.talismanrc checksum: Talisman flags the setup-URL warning line.

#claude_code#
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@Harshi-Shah-CS
Harshi-Shah-CS requested review from a team as code owners October 29, 2026 16:07
@snyk-io

snyk-io Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 0 0 10 ✅ Passed
🟠 High Severity 0 10 25 ✅ Passed
🟡 Medium Severity 0 2 500 ✅ Passed
🔵 Low Severity 0 0 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

ℹ️ Vulnerabilities Without Available Fixes (Informational Only)

The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:

  • Critical without fixes: 0
  • High without fixes: 10
  • Medium without fixes: 2
  • Low without fixes: 0

✅ BUILD PASSED - All security checks passed

@Harshi-Shah-CS Harshi-Shah-CS changed the title chore(hooks): add ggshield secret scan to husky hooks and drop secrets-scan workflow (+Claude) chore(hooks): add ggshield secret scan to husky hooks and drop secrets-scan workflow Oct 29, 2026
@Harshi-Shah-CS
Harshi-Shah-CS merged commit 42f1b9b into development Oct 29, 2026
7 checks passed
@Harshi-Shah-CS
Harshi-Shah-CS deleted the CL-0000_ggshield-hooks branch October 29, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ Proxy