Skip to content

Document undefined behavior for non-standard ERC-20 tokens - #671

Open
kaze-cow wants to merge 2 commits into
mainfrom
docs/non-standard-erc20-known-issue
Open

kaze-cow wants to merge 2 commits into
mainfrom
docs/non-standard-erc20-known-issue

Conversation

@kaze-cow

@kaze-cow kaze-cow commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Adds a "Non-standard ERC-20 tokens" subsection to the core contracts Security / Known Issues section.

It states that the protocol assumes transfer/transferFrom move exactly the requested amount, and that tokens deviating from this (e.g. fee-on-transfer, rebasing) are unsupported and their behavior in orders and settlements is undefined. Links to the supported tokens page.

This was already known to be the case and vaguely explained in https://docs.cow.fi/cow-protocol/reference/core/tokens. The purpose of this PR is to make it more clear because we continue to get bug reports regarding the smart contract behavior and need to make sure this is clearly documented.

🤖 Generated with Claude Code

…ssues

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kaze-cow
kaze-cow requested a review from a team as a code owner October 19, 2026 08:05
@vercel

vercel Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 19, 2026 8:08am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2d20ae45-c3fd-4ba2-b347-078b5b64ca09
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@fedgiac fedgiac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't assume ERC20, otherwise USDT wouldn't be tradable. 😛

I wouldn't say this is a "known security issue" but it's more something that limits the scope of what we consider a vulnerability, or "known behavior."

My suggestion would be to move this explanation to "supported tokens" and link to that if people report a related vulnerability.
Note that having this "vulnerability" here won't necessarily stop people from submitting a related report, what we want is just being able to dismiss these quickly with a link.

If you still think we should add it here, then we should restructure the document so that it makes it clear that we're listing things that aren't a vulnerability but that are often mistakenly reported.

This branch was successfully deployed

1 active deployment
Preview — 0838c11a Deployed Oct 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ Proxy