Repository navigation
fix: ts esm types (close #173) - #174
Closed
Mister-Hope wants to merge 1 commit into
Closed
Mister-Hope wants to merge 1 commit into
Mister-Hope wants to merge 1 commit into
Conversation
Contributor
Author
|
@developit Could you please review this pr and publish a 3.0.1 soon? I am patching this package for quite a long time. |
rschristian
reviewed
Nov 26, 2022
Comment on lines
+5
to
7
| "type": "module", | ||
| "module": "dist/mitt.mjs", | ||
| "main": "dist/mitt.js", |
There was a problem hiding this comment.
This is incorrect and not viable (on its own). Setting the package type to "module" means all of those .js files will be treated as ESM when they're CJS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.