Skip to content

Always use caching #3

Closed
Closed

Description

@frwiqueueit

This needs to be fixed. If not, it will cause issues, while download of config will follow the number of people (requests) hitting your website. We (queue-it) can't guarantee that all these requests for integration configurations will be allowed by firewall etc. (while this is not normal behavior).

return file_get_contents($this->getIntegrationConfigPath());

Activity

  1. kenorb commented on Dec 5, 2018

    @kenorb
    Member

    I've pushed some caching changes which I already had, you can see them in PR (GH-4), it's almost completed. We haven't deployed it yet. We'll need to test them.

  2. added a commit that references this issue on Jan 7, 2019
  3. kenorb commented on Jan 7, 2019

    @kenorb
    Member

    GH-4 with cache fixes has been merged.
    This will be deployed to NT somewhere this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      ⌂ Proxy