[reidbaker-agent]

Fixes #253

skills.sh.json used groups, but the skills.sh schema expects groupings and sets additionalProperties: false. Its $schema URL also returned a 404. This change:

• Renames groups to groupings.
• Points $schema at https://skills.sh/schemas/skills.sh.schema.json.
• Updates tool/generator/test/lint_skills_test.dart to read groupings, expect the new URL, and fail on any top-level or group key the schema does not allow.
• Updates the generator README and fixes a test comment that listed hidden as a valid notGrouped value (the schema allows only top and bottom).

No other mismatches: notGrouped: "bottom" and every group's title, description and skills match the schema.

Validation against the live schema with Python jsonschema (Draft 2020-12, as the schema declares):

$ python3 validate.py skills.sh.json
valid
$ python3 validate.py skills.sh.json   # before this change
ERROR: Additional properties are not allowed ('groups' was unexpected)
ERROR: 'groupings' is a required property
invalid

dart analyze --fatal-infos, dart format and dart test pass in tool/generator.

[gemini-code-assist]

Code Review

This pull request updates the schema URL and renames the 'groups' property to 'groupings' in 'skills.sh.json' to align with the latest schema definition. Corresponding updates are made to the generator's documentation and the lint tests, which now also validate that only allowed keys are present. The review feedback suggests enhancing the test assertions by explicitly verifying the types of the 'groupings' list and the required 'skills' property to prevent cryptic type errors during parsing.

[gemini-code-assist]

To prevent cryptic TypeErrors when parsing skills.sh.json (e.g., if groupings is missing, null, or not a list of maps), it is safer to explicitly assert the type of groupings and its elements using expect before casting.

Suggested change

	final groups = (skillsShJson['groupings'] as List<Object?>)
	.cast<Map<String, Object?>>();
	expect(skillsShJson['groupings'], isA<List<Object?>>());
	final groupingsList = skillsShJson['groupings'] as List<Object?>;
	expect(groupingsList, everyElement(isA<Map<String, Object?>>()));
	final groups = groupingsList.cast<Map<String, Object?>>();

[gemini-code-assist]

While we validate that the keys of each group only contain allowed properties, we should also explicitly assert that the required skills property is present and is a list. This provides a clear failure message if a group is missing its skills list, rather than throwing a TypeError later in _collectUniqueGroupedSkills.

Suggested change

	expect(
	group.keys,
	everyElement(isIn(['title', 'description', 'skills'])),
	);
	expect(
	group.keys,
	everyElement(isIn(['title', 'description', 'skills'])),
	);
	expect(group['skills'], isA<List<Object?>>());

[reidbaker]

Examples from other repos that use groupings not groups.
https://github.com/expo/skills/blob/main/skills.sh.json
https://github.com/NVIDIA/skills/blob/main/skills.sh.json

[reidbaker]

Best I can tell this url did not exist.

[reidbaker]

@johnpryan would you like me to wait on your reviews for this repo?