Skip to content

[material_ui] Let the LicensePage loading state scroll - #13503

Draft
theprantadutta wants to merge 1 commit into
flutter:mainfrom
theprantadutta:material_ui/license-page-loading-overflow
Draft

theprantadutta wants to merge 1 commit into
flutter:mainfrom
theprantadutta:material_ui/license-page-loading-overflow

Conversation

@theprantadutta

Copy link
Copy Markdown
Contributor

While the licenses load, _PackagesViewState shows the app header (widget.about: the app name, version, legalese and "Powered by Flutter") above a CircularProgressIndicator, in a Column that can't scroll. When the two are taller than the screen, as on a landscape phone with large text, the column overflows. Once the licenses have loaded the page is fine, because the loaded list is a ListView.

The fix wraps the loading Column in a SingleChildScrollView.

Tests

One regression test in about_test.dart shows the page on a landscape phone (844x390) with the text scaled to 200%, and checks that the loading state doesn't overflow and that the progress indicator is inside a scrollable. It fails on main with A RenderFlex overflowed by 8.0 pixels on the bottom. and passes with the fix. The rest of about_test.dart passes, including the tests that check the page's color and Material count while loading (63 tests, plus one web-only skip), and so does the about_list_tile.0 example test.

Fixes flutter/flutter#195685

This is a draft because I'm at the open pull request limit for this repository. I'll mark it ready for review when a slot frees up.

Pre-Review Checklist

I used AI tooling while working on this, and reviewed and tested all of it myself.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2

While the licenses load, the page showed the app header and a progress
indicator in a Column that couldn't scroll, so on a short screen or with
large text it overflowed. Wrap it in a SingleChildScrollView, as the
loaded list already scrolls.

Fixes flutter/flutter#195685
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p: material_ui triage-design Should be looked at in design triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LicensePage: the loading state overflows on a landscape phone at large text

1 participant

⌂ Proxy