Repository navigation
[material_ui] Let the LicensePage loading state scroll - #13503
Draft
theprantadutta wants to merge 1 commit into
Draft
theprantadutta wants to merge 1 commit into
theprantadutta wants to merge 1 commit into
Conversation
While the licenses load, the page showed the app header and a progress indicator in a Column that couldn't scroll, so on a short screen or with large text it overflowed. Wrap it in a SingleChildScrollView, as the loaded list already scrolls. Fixes flutter/flutter#195685
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the licenses load,
_PackagesViewStateshows the app header (widget.about: the app name, version, legalese and "Powered by Flutter") above aCircularProgressIndicator, in aColumnthat can't scroll. When the two are taller than the screen, as on a landscape phone with large text, the column overflows. Once the licenses have loaded the page is fine, because the loaded list is aListView.The fix wraps the loading
Columnin aSingleChildScrollView.Tests
One regression test in
about_test.dartshows the page on a landscape phone (844x390) with the text scaled to 200%, and checks that the loading state doesn't overflow and that the progress indicator is inside a scrollable. It fails onmainwithA RenderFlex overflowed by 8.0 pixels on the bottom.and passes with the fix. The rest ofabout_test.dartpasses, including the tests that check the page's color and Material count while loading (63 tests, plus one web-only skip), and so does theabout_list_tile.0example test.Fixes flutter/flutter#195685
This is a draft because I'm at the open pull request limit for this repository. I'll mark it ready for review when a slot frees up.
Pre-Review Checklist
[shared_preferences]///).I used AI tooling while working on this, and reviewed and tested all of it myself.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2