Repository navigation
Fix the counterfactual_fairness run script so it actually starts - #763
Open
rootkiller6788 wants to merge 3 commits into
Open
rootkiller6788 wants to merge 3 commits into
rootkiller6788 wants to merge 3 commits into
Conversation
adult._read_data was doing `with os.path.join(...) as data_file`, which tries to use a plain path string as a context manager and blows up with TypeError. Wrap it in open() so the csv is actually read.
run_adult_pscf.sh calls adult_pscf with --dataset_dir and --num_steps but neither flag was defined, so absl bailed out with an unknown-flag error before main even started. dataset_dir feeds read_all_data, and num_steps falls back to the config value when it's not given.
download_dataset.sh was told to write into TMP_DIR while --dataset_dir pointed at TMP_DIR/adult, so read_all_data looked for the files in a subdir that never got populated. Point the download at DATA_DIR.
|
Dooray! 메일 발송 실패 안내
메일 발송
실패 안내
***@***.***)
님께
보낸
메일이
전송되지
못하였습니다.
실패 사유를 확인해보세요.
* 받는 사람 :
***@***.***)
* 발송 시간 :
2026-08-30T18:47:05
* 메일 제목 :
[google-deepmind/deepmind-research] Fix the counterfactual_fairness run script so it actually starts (PR #763)
* 실패 사유 :
받는 사람이 현재 메일 수신을 제한하고 있습니다.
이 설정은 개인 또는 조직의 메일 수신 정책에 의해 적용되었습니다.
이 메일은 발신전용으로 회신되지 않습니다.
더 궁금하신 사항은
***@***.***
으로 문의해 주시기 바랍니다.
© Dooray!.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run_adult_pscf.sh hasn't been runnable for a while. absl refuses the --dataset_dir / --num_steps flags the script passes because they were never defined, and once you get past that, adult._read_data crashes trying to use a path string as a context manager, and the data lands in a different directory than --dataset_dir reads.
This defines the two missing flags, opens the csv file with open(), and has download_dataset.sh write into DATA_DIR so the paths line up. num_steps only overrides the config when it's actually passed, so existing usage is unchanged.
Verified by importing adult_pscf with the heavy deps stubbed and parsing the exact command line the script emits (original bails with UnrecognizedFlagError, fixed parses cleanly), and by running _read_data against a small synthetic csv. Closes #421.