Repository navigation
Conversation
create_session computed has_user_provided_id from 'session_id is not None', so an empty string was accepted as a user-provided id and stored verbatim. A session stored under id '' is unaddressable through the HTTP API and collides with every other empty-id creation for the same (app, user) pair. Every other backend (in-memory, sqlite, redis, mongodb, firestore) treats an empty id as absent and generates one. Derive has_user_provided_id from the truthiness of session_id and generate a uuid when it is falsy, matching the other backends. Adds a conformance test that an empty id yields a non-empty generated id across backends.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DatabaseSessionService.create_sessioncomputedhas_user_provided_idfromsession_id is not None, so an empty string was accepted as a user-provided id and stored verbatim. A session stored under id''is unaddressable through the HTTP API and collides with every other empty-id creation for the same(app, user)pair (the second creation raisesAlreadyExistsError). Every other backend (in-memory, sqlite, redis, mongodb, firestore) treats an empty id as absent and generates one.Changes
has_user_provided_idfrom the truthiness ofsession_idand generate a uuid when it is falsy, matching the other backends.Tests
Adds a conformance test
test_create_session_with_empty_id_generates_one(parameterized across the registered backends) asserting that an empty id yields a non-empty generated id.