Skip to content

Tag type creation and crud functions - #7928

Merged
mekarpeles merged 10 commits into
internetarchive:masterfrom
JaydenTeoh:feature/tags-crud
Jul 3, 2023
Merged

mekarpeles merged 10 commits into
internetarchive:masterfrom
JaydenTeoh:feature/tags-crud

Conversation

@JaydenTeoh

Copy link
Copy Markdown
Collaborator

This is a PR containing only Tag type creation and its basic crud functions. This allows us divide the original Tags PR #7766 into segments to be added into production for easier testing.

Stakeholders

@mekarpeles

@JaydenTeoh
JaydenTeoh force-pushed the feature/tags-crud branch from 4b62ff6 to c94708b Compare June 3, 2023 17:22
@mekarpeles mekarpeles self-assigned this Jun 5, 2023
Comment thread openlibrary/core/models.py Resolved
@jimchamp

jimchamp commented Jun 8, 2023

Copy link
Copy Markdown
Collaborator

I would be great if the DDL was included with this PR. It could be added to https://github.com/internetarchive/openlibrary/blob/master/openlibrary/core/infobase_schema.sql, which contains DDL for many other Infogami types.

@JaydenTeoh

JaydenTeoh commented Jun 9, 2023 •

Copy link
Copy Markdown
Collaborator Author

@jimchamp Hi Jim, I've added the DDL for tags as requested, would you mind taking a look to verify that I have not missed anything out? Thank you!

@JaydenTeoh

Copy link
Copy Markdown
Collaborator Author

@mekarpeles Made a small change to remove duplicate Tag class registration as an Infogami 'Thing' within the recent commit. Let's test the staging of this PR again just to be sure it does not affect anything.

Comment thread openlibrary/core/schema.py Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ Proxy