Repository navigation
feat(core): Remove EOL Python 3.10 support - #41267
Christophe Bornet (cbornet) wants to merge 4 commits into
Conversation
16475fc to
a913a2f
Compare
Merging this PR will improve performance by 18.4%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | test_convert_tools_cold |
193.5 ms | 158.2 ms | +22.28% |
| ⚡ | test_import_time[BaseChatModel] |
2.1 s | 1.8 s | +14.65% |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing cbornet:remove-py310 (d1a472a) with master (bd5b134)2
Footnotes
-
2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
master(afafd55) during the generation of this report, so bd5b134 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
a913a2f to
769b332
Compare
769b332 to
f6c247d
Compare
Bicheng (Kenneth) (BichengWang)
left a comment
There was a problem hiding this comment.
[P1] test-dependents cannot use its own matrix to define python-version.
At head f6c247de40e56d0747fead679ad1a5177fa0930c, the new python-version: ${{ matrix.python-version }} in strategy.matrix makes the Integration Tests workflow invalid. The matrix context is unavailable while GitHub evaluates strategy, so this blocks scheduled and manually dispatched runs before the jobs start. GitHub's context availability reference lists only github, needs, vars, and inputs for this location.
The compute-matrix output already contains the Python versions. This replacement passes validation and preserves the override:
python-version: ${{ fromJSON(needs.compute-matrix.outputs.matrix).python-version }}I ran actionlint 1.7.12 with -shellcheck= -pyflakes= on the complete workflow: the PR base (c088db971097f0f12c7b8c30d473e8dbde09c823) and current master (b7b942a7ffd3206e1b572f4d0639377bca4750d7) pass; this head fails with context "matrix" is not allowed here; a temporary copy with the replacement passes. I also executed the head's matrix-generation shell step offline: it emits ["3.11", "3.14"] by default and ["3.12"] with that override.
This review is scoped to the integration workflow change.
f6c247d to
3522902
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Fixed integration test. |
| py_versions = ["3.11", "3.12", "3.13", "3.14"] | ||
| else: | ||
| py_versions = ["3.10", "3.14"] | ||
| py_versions = ["3.11", "3.14"] |
There was a problem hiding this comment.
Most libs depend on core so we can't test them in 3.10 anymore.
7f5a1e2 to
d1a472a
Compare
Uh oh!
There was an error while loading. Please reload this page.