Repository navigation
ci(fresh-install): the tumbleweed leg refreshes before it installs and stops when the refresh fails - #871
Open
NopeCharon wants to merge 1 commit into
Open
ci(fresh-install): the tumbleweed leg refreshes before it installs and stops when the refresh fails#871NopeCharon wants to merge 1 commit into
NopeCharon wants to merge 1 commit into
Conversation
…d stops when the refresh fails
The tumbleweed leg ran `zypper -n install ...` alone. That install refreshes
the repositories itself, and when the refresh fails it continues on stale or
empty metadata, so the leg went red with
Some of the repositories have not been refreshed because of an error.
No provider of 'binutils' found.
The second line is the one a reader acts on, and it names a package rather
than the repository that could not be read.
The leg's setup now runs `zypper -n --gpg-auto-import-keys refresh` as its
own command, retries it once after 15 seconds, and installs only after it
succeeds. A refresh that fails twice ends the step with zypper's own refresh
error and status. --gpg-auto-import-keys accepts a repository's new signing
key, which `-n` alone rejects on a rolling image.
Measured in opensuse/tumbleweed:latest (aarch64) under `sh -e`, as a
container step runs: with a repository at an unreachable URL added, both
refreshes fail, the install never starts and the step exits 4 after
"Some of the repositories have not been refreshed"; without it the refresh
succeeds and the install proceeds.
Closes mcpp-community#523.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Linux distro (tumbleweed)leg ofci-fresh-installranzypper -n install ...alone. That install refreshes the repositories first, and when the refresh fails it keeps going on stale or empty metadata. The leg then went red withNo provider of 'binutils' found, which names a package and not the repository that could not be read.The leg's setup now runs
zypper -n --gpg-auto-import-keys refreshas its own command and retries it once after 15 seconds. The install runs only after a refresh succeeds. If the refresh fails twice, the step ends with zypper's own refresh error and exit status.--gpg-auto-import-keysaccepts a repository's new signing key, which-nalone rejects. A rolling image can run into such a key.Closes #523.
Criteria
setupstring undersh -einopensuse/tumbleweed:latest(aarch64), the shell GitHub uses for a container step. I checked it against the value the YAML parses to.No provider of ...errors.python3 .github/tools/check_workflow_assertions.pypasses.Intersections
findutils,binutilsandfilebefore mcpp runsInstall prerequisitesstep itself: the install line is unchangedInstall xlings + mcppruns only after the prerequisites step succeedsCompatibility
This changes only the tumbleweed leg. Before, a refresh failure in any configured repository could slip through if the install still found its packages. Now that failure fails the leg, after one retry, and the error names the repository.
Checks before merging
bash .github/tools/check_docs_style.sh,check_docs_structure.shandcheck_version_pins.shpass.python3 .github/tools/check_workflow_assertions.pypasses (a step asserts what its name says).git log origin/main..HEAD -i --grep='Co-Authored-By'prints nothing.compose one from the branch's commits. Suggested subject:
ci(fresh-install): the tumbleweed leg refreshes before it installs and stops when the refresh fails.