Compute CommonJSModuleIndicator in the parser by jakebailey · Pull Request #65073 · microsoft/TypeScript

Jake Bailey (jakebailey) · 2026-10-31T06:15:58Z

CommonJSModuleIndicator is read on files when seeing if they can be reused. But, that field is only set when a file has been bound! This means that file reuse is racy, but also inconsistent depending on when something was bound.

Instead of doing something drastic like forcing a bind just to check reuse, move this info gathering to the parser, which can calculate the same thing earlier.

Funnily, the SourceFile type already had CommonJSModuleIndicator in the parser-owned field section, which was wrong.

Unfortunately, CommonJSModuleIndicator depends on JSDoc nodes, so this requires a bit more care. I think it using JSDoc nodes is utterly strange, but, that's what we've always done, even before TS 7.

Arguably, we don't even need to set a node for CommonJSModuleIndicator or have one at all, it's not in the public JS API. I might push again to this PR and just make it a bool or tristate or something. Though it not being there but part of the reuse calculation makes me wonder if it should actually be in the AST API after all? Opted to not, because actually that node's normally used for the CJS-to-ESM fix, which, we never ported

Copilot

🟡 Changes recommended

Two critical reparsing defects leave CommonJS module indicators missing or stale, causing binding panics for valid JavaScript inputs.

2 open issues

What changed in this PR

Moves CommonJS module detection from the binder to the parser so program reuse decisions no longer depend on whether a file has been bound.

Changes:

Tracks CommonJS constructs during parsing, including reparsed JSDoc nodes.
Updates the binder to consume parser-owned metadata while preserving symbol creation order.
Adds tests for module detection and program reuse across CommonJS edits.

File	Description
`tsc/internal/parser/reparser.go`	Checks cloned JSDoc nodes for CommonJS constructs.
`tsc/internal/parser/parser.go`	Tracks and publishes CommonJS module indicators during parsing.
`tsc/internal/parser/parser_test.go`	Adds CommonJS detection cases.
`tsc/internal/compiler/program_test.go`	Tests reuse across CommonJS edits and script transitions.
`tsc/internal/binder/binder.go`	Uses parser metadata while retaining deferred module symbol creation.

_{Review effort: Balanced}

Jake Bailey (jakebailey) · 2026-10-31T06:44:12Z

Uh. Interesting

CommonJSModuleIndicator was only set by the binder, so any reader of an unbound file saw nil and treated a CommonJS JS file as a script. In particular, canReplaceFileInProgram compares module-ness of the old (usually bound) file against the freshly parsed new file, so editing any CommonJS file always rebuilt the whole program, while a script turning into CommonJS was wrongly reused. The binder also wrote this field on files shared between programs via the parse cache. Whether a file is CommonJS is purely syntactic, so the parser now records it as SourceFile.IsCommonJSModule. Nothing read the indicator node itself, so a bool is enough. Reparsed JSDoc nodes count too, since the binder visits them. The binder no longer writes the field, but still creates the file symbol at the first CommonJS construct to keep symbol creation order, and asserts that it agrees with the parser.

Copilot

🔵 Needs a closer look

The parser/binder ownership change requires classification parity across JSDoc and top-level-await reparsing while preserving symbol order, but the necessary compiler, binder regression, and race-test validation is unavailable in this review environment.

No open issues 🎉

2 resolved since last review

_{Review effort: Balanced}

Go back to storing the indicator node rather than a bool. TypeScript 6.0 reported the "File is a CommonJS module; it may be converted to an ES module" suggestion at this node, and keeping it avoids having to find the construct again if that suggestion is ported.

Jake Bailey (jakebailey) · 2026-10-31T20:32:48Z

TypeScript Bot (@typescript-bot) perf test this faster

typescript-automation · 2026-10-31T20:32:53Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this faster`	✅ Started	👀 Results

typescript-automation · 2026-10-31T21:23:26Z

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - native}
_Errors	₄₁	₄₁	_~	_~	_~	_{p=1.000 n=20}
_Symbols	_88,466	_88,466	_~	_~	_~	_{p=1.000 n=20}
_Types	_79,607	_79,607	_~	_~	_~	_{p=1.000 n=20}
_{Memory Used}	_{107,502k (± 0.03%)}	_{107,490k (± 0.03%)}	_~	_107,338k	_107,624k	_{p=0.733 n=20}
_{Memory Allocs}	_{1,262,149 (± 0.01%)}	_{1,262,168 (± 0.01%)}	_~	_1,261,534	_1,262,476	_{p=0.410 n=20}
_{Config Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=20}
_{Parse Time}	_{0.023s (± 2.16%)}	_{0.023s (± 2.77%)}	_~	_0.020s	_0.026s	_{p=0.108 n=20}
_{Bind Time}	_{0.008s (± 6.05%)}	_{0.008s (± 5.25%)}	_~	_0.007s	_0.010s	_{p=0.703 n=20}
_{Check Time}	_{0.210s (± 0.93%)}	_{0.209s (± 0.49%)}	_~	_0.205s	_0.214s	_{p=0.834 n=20}
_{Emit Time}	_{0.132s (± 1.70%)}	_{0.130s (± 0.91%)}	_~	_0.126s	_0.137s	_{p=0.403 n=20}
_{Total Time}	_{0.376s (± 1.14%)}	_{0.374s (± 0.49%)}	_~	_0.366s	_0.382s	_{p=0.899 n=20}
_{angular-1 - native}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=20}
_Symbols	_586,553	_586,553	_~	_~	_~	_{p=1.000 n=20}
_Types	_241,682	_241,682	_~	_~	_~	_{p=1.000 n=20}
_{Memory Used}	_{519,754k (± 0.02%)}	_{519,763k (± 0.02%)}	_~	_519,235k	_520,022k	_{p=0.825 n=20}
_{Memory Allocs}	_{7,791,539 (± 0.08%)}	_{7,788,199 (± 0.05%)}	_~	_7,777,908	_7,807,618	_{p=0.718 n=20}
_{Config Time}	_0.008s	_{0.008s (± 1.30%)}	_~	_0.008s	_0.009s	_{p=1.000 n=20}
_{Parse Time}	_{0.124s (± 3.38%)}	_{0.123s (± 3.34%)}	_~	_0.115s	_0.149s	_{p=0.692 n=20}
_{Bind Time}	_{0.045s (±10.72%)}	_{0.040s (± 8.46%)}	_~	_0.035s	_0.064s	_{p=0.234 n=20}
_{Check Time}	_0s	_0s	_~	_~	_~	_{p=1.000 n=20}
_{Emit Time}	_{0.624s (± 0.45%)}	_{0.629s (± 0.79%)}	_~	_0.617s	_0.658s	_{p=0.121 n=20}
_{Total Time}	_{0.814s (± 0.70%)}	_{0.810s (± 0.82%)}	_~	_0.789s	_0.834s	_{p=0.279 n=20}
_{arktype - native}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=20}
_Symbols	_685,920	_685,920	_~	_~	_~	_{p=1.000 n=20}
_Types	_939,467	_939,467	_~	_~	_~	_{p=1.000 n=20}
_{Memory Used}	_{495,352k (± 0.01%)}	_{495,338k (± 0.01%)}	_~	_495,160k	_495,566k	_{p=0.417 n=20}
_{Memory Allocs}	_{12,064,474 (± 0.02%)}	_{12,061,305 (± 0.01%)}	_~	_12,057,703	_12,066,378	_{p=0.060 n=20}
_{Config Time}	_0.001s	_0.001s	_~	_~	_~	_{p=1.000 n=20}
_{Parse Time}	_{0.043s (± 3.69%)}	_{0.043s (± 4.00%)}	_~	_0.037s	_0.053s	_{p=0.752 n=20}
_{Bind Time}	_{0.013s (± 9.80%)}	_{0.013s (± 8.69%)}	_~	_0.011s	_0.020s	_{p=0.565 n=20}
_{Check Time}	_{0.903s (± 1.04%)}	_{0.900s (± 1.03%)}	_~	_0.876s	_0.945s	_{p=0.433 n=20}
_{Emit Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=20}
_{Total Time}	_{0.988s (± 0.83%)}	_{0.986s (± 0.92%)}	_~	_0.960s	_1.030s	_{p=0.516 n=20}
_{class-transformer - native}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=20}
_Symbols	_45,376	_45,376	_~	_~	_~	_{p=1.000 n=20}
_Types	_7,573	_7,573	_~	_~	_~	_{p=1.000 n=20}
_{Memory Used}	_{27,893k (± 0.02%)}	_{27,898k (± 0.03%)}	_~	_27,845k	_27,932k	_{p=0.132 n=20}
_{Memory Allocs}	_{248,367 (± 0.07%)}	_{248,308 (± 0.08%)}	_~	_247,804	_249,498	_{p=0.199 n=20}
_{Config Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=20}
_{Parse Time}	_{0.012s (± 3.09%)}	_{0.012s (± 4.24%)}	_~	_0.009s	_0.013s	_{p=0.735 n=20}
_{Bind Time}	_{0.003s (±12.11%)}	_{0.004s (±10.14%)}	_~	_0.003s	_0.005s	_{p=0.536 n=20}
_{Check Time}	_{0.008s (± 7.01%)}	_{0.008s (± 6.89%)}	_~	_0.006s	_0.010s	_{p=0.990 n=20}
_{Emit Time}	_{0.008s (± 6.11%)}	_{0.008s (±10.31%)}	_~	_0.006s	_0.012s	_{p=0.807 n=20}
_{Total Time}	_{0.031s (± 2.00%)}	_{0.032s (± 2.70%)}	_~	_0.030s	_0.038s	_{p=0.945 n=20}
_{effect - native}
_Errors	₁₂	₁₂	_~	_~	_~	_{p=1.000 n=20}
_Symbols	_1,235,115	_1,235,115	_~	_~	_~	_{p=1.000 n=20}
_Types	_894,113	_894,113	_~	_~	_~	_{p=1.000 n=20}
_{Memory Used}	_{949,830k (± 0.02%)}	_{949,928k (± 0.02%)}	_~	_949,050k	_950,597k	_{p=0.355 n=20}
_{Memory Allocs}	_{12,636,424 (± 0.02%)}	_{12,635,472 (± 0.02%)}	_~	_12,628,243	_12,644,308	_{p=0.678 n=20}
_{Config Time}	_0.002s	_{0.002s (± 9.93%)}	_~	_0.002s	_0.004s	_{p=1.000 n=20}
_{Parse Time}	_{0.147s (± 1.28%)}	_{0.153s (± 3.23%)}	_{🔻+0.006s (+ 4.19%)}	_0.142s	_0.192s	_{p=0.019 n=20}
_{Bind Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=20}
_{Check Time}	_{0.874s (± 0.65%)}	_{0.884s (± 1.33%)}	_~	_0.856s	_0.961s	_{p=0.358 n=20}
_{Emit Time}	_{0.504s (± 1.70%)}	_{0.487s (± 1.47%)}	_{🟩-0.017s (- 3.37%)}	_0.459s	_0.511s	_{p=0.004 n=20}
_{Total Time}	_{1.622s (± 0.62%)}	_{1.616s (± 0.58%)}	_~	_1.595s	_1.677s	_{p=0.213 n=20}
_{mui-docs - native}
_Errors	_11,405	_11,405	_~	_~	_~	_{p=1.000 n=20}
_Symbols	_3,784,019	_3,784,019	_~	_~	_~	_{p=1.000 n=20}
_Types	_1,355,974	_1,355,974	_~	_~	_~	_{p=1.000 n=20}
_{Memory Used}	_{1,768,458k (± 0.10%)}	_{1,767,814k (± 0.09%)}	_~	_1,759,864k	_1,773,404k	_{p=0.758 n=20}
_{Memory Allocs}	_{25,755,571 (± 0.14%)}	_{25,736,697 (± 0.14%)}	_~	_25,643,401	_25,900,809	_{p=0.341 n=20}
_{Config Time}	_{0.008s (± 1.30%)}	_{0.008s (± 2.51%)}	_~	_0.008s	_0.009s	_{p=0.182 n=20}
_{Parse Time}	_{0.288s (± 2.18%)}	_{0.287s (± 2.01%)}	_~	_0.267s	_0.309s	_{p=0.973 n=20}
_{Bind Time}	_0.001s	_0.001s	_~	_~	_~	_{p=1.000 n=20}
_{Check Time}	_{2.987s (± 0.84%)}	_{2.979s (± 0.75%)}	_~	_2.901s	_3.073s	_{p=0.664 n=20}
_{Emit Time}	_{0.245s (± 1.18%)}	_{0.244s (± 0.89%)}	_~	_0.236s	_0.251s	_{p=0.448 n=20}
_{Total Time}	_{4.018s (± 0.71%)}	_{4.003s (± 0.55%)}	_~	_3.923s	_4.106s	_{p=0.402 n=20}
_{sentry - native}
_Errors	₂	₂	_~	_~	_~	_{p=1.000 n=20}
_Symbols	_4,793,245	_4,793,245	_~	_~	_~	_{p=1.000 n=20}
_Types	_2,606,905	_2,606,905	_~	_~	_~	_{p=1.000 n=20}
_{Memory Used}	_{2,845,899k (± 0.03%)}	_{2,846,374k (± 0.03%)}	_~	_2,843,794k	_2,850,985k	_{p=0.495 n=20}
_{Memory Allocs}	_{74,972,820 (± 0.17%)}	_{74,944,646 (± 0.11%)}	_~	_74,670,117	_75,422,986	_{p=0.904 n=20}
_{Config Time}	_{0.025s (± 0.58%)}	_{0.025s (± 0.69%)}	_~	_0.024s	_0.025s	_{p=1.000 n=20}
_{Parse Time}	_{0.461s (± 5.66%)}	_{0.477s (± 5.98%)}	_~	_0.419s	_0.658s	_{p=0.194 n=20}
_{Bind Time}	_{0.174s (±11.12%)}	_{0.157s (± 9.57%)}	_~	_0.127s	_0.226s	_{p=0.324 n=20}
_{Check Time}	_{6.550s (± 0.52%)}	_{6.579s (± 0.57%)}	_~	_6.448s	_6.732s	_{p=0.239 n=20}
_{Emit Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=20}
_{Total Time}	_{7.265s (± 0.44%)}	_{7.290s (± 0.55%)}	_~	_7.166s	_7.497s	_{p=0.331 n=20}
_{social-app - native}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=20}
_Symbols	_1,883,074	_1,883,074	_~	_~	_~	_{p=1.000 n=20}
_Types	_1,158,168	_1,158,168	_~	_~	_~	_{p=1.000 n=20}
_{Memory Used}	_{967,072k (± 0.02%)}	_{966,975k (± 0.02%)}	_~	_966,237k	_967,715k	_{p=0.394 n=20}
_{Memory Allocs}	_{13,527,178 (± 0.31%)}	_{13,500,970 (± 0.16%)}	_~	_13,438,596	_13,584,194	_{p=0.602 n=20}
_{Config Time}	_0.007s	_{0.007s (± 2.02%)}	_~	_0.007s	_0.008s	_{p=0.487 n=20}
_{Parse Time}	_{0.154s (± 3.49%)}	_{0.152s (± 1.80%)}	_~	_0.142s	_0.163s	_{p=0.984 n=20}
_{Bind Time}	_{0.042s (±11.07%)}	_{0.042s (± 8.17%)}	_~	_0.036s	_0.062s	_{p=0.275 n=20}
_{Check Time}	_{1.384s (± 0.72%)}	_{1.382s (± 0.66%)}	_~	_1.350s	_1.410s	_{p=0.723 n=20}
_{Emit Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=20}
_{Total Time}	_{1.604s (± 0.52%)}	_{1.602s (± 0.51%)}	_~	_1.568s	_1.644s	_{p=0.763 n=20}
_{strada-build-src - native}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=20}
_Symbols	_1,184,972	_1,184,972	_~	_~	_~	_{p=1.000 n=20}
_Types	_438,959	_438,959	_~	_~	_~	_{p=1.000 n=20}
_{Memory Used}	_{1,169,390k (± 0.27%)}	_{1,171,727k (± 0.40%)}	_~	_1,156,220k	_1,193,464k	_{p=0.820 n=20}
_{Memory Allocs}	_{47,593,795 (± 0.13%)}	_{47,555,272 (± 0.11%)}	_~	_47,352,987	_47,795,534	_{p=0.211 n=20}
_{Config Time}	_{0.002s (±18.03%)}	_{0.002s (±15.67%)}	_~	_0.000s	_0.002s	_{p=1.000 n=20}
_{Parse Time}	_{0.141s (± 1.37%)}	_{0.143s (± 2.17%)}	_~	_0.130s	_0.160s	_{p=0.166 n=20}
_{Bind Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=20}
_{Check Time}	_{0.824s (± 1.00%)}	_{0.822s (± 0.98%)}	_~	_0.800s	_0.858s	_{p=0.825 n=20}
_{Emit Time}	_{0.147s (± 3.44%)}	_{0.146s (± 2.38%)}	_~	_0.138s	_0.164s	_{p=0.952 n=20}
_{Total Time}	_{9.491s (± 0.63%)}	_{9.589s (± 1.06%)}	_~	_9.322s	_10.061s	_{p=0.199 n=20}
_{strada-compiler - native}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=20}
_Symbols	_263,511	_263,511	_~	_~	_~	_{p=1.000 n=20}
_Types	_196,116	_196,116	_~	_~	_~	_{p=1.000 n=20}
_{Memory Used}	_{223,575k (± 0.02%)}	_{223,531k (± 0.02%)}	_~	_223,312k	_223,758k	_{p=0.165 n=20}
_{Memory Allocs}	_{2,389,705 (± 0.01%)}	_{2,389,422 (± 0.01%)}	_~	_2,388,109	_2,390,392	_{p=0.231 n=20}
_{Config Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=20}
_{Parse Time}	_{0.049s (± 3.06%)}	_{0.049s (± 2.88%)}	_~	_0.044s	_0.056s	_{p=0.479 n=20}
_{Bind Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=20}
_{Check Time}	_{0.370s (± 0.66%)}	_{0.374s (± 3.21%)}	_~	_0.359s	_0.481s	_{p=0.673 n=20}
_{Emit Time}	_{0.046s (± 4.35%)}	_{0.047s (± 5.16%)}	_~	_0.042s	_0.058s	_{p=0.557 n=20}
_{Total Time}	_{0.490s (± 0.63%)}	_{0.498s (± 2.45%)}	_~	_0.477s	_0.604s	_{p=0.166 n=20}
_{t3code-server - native}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=20}
_Symbols	_4,350,661	_4,350,661	_~	_~	_~	_{p=1.000 n=20}
_Types	_3,040,644	_3,040,644	_~	_~	_~	_{p=1.000 n=20}
_{Memory Used}	_{2,417,498k (± 0.02%)}	_{2,417,341k (± 0.02%)}	_~	_2,416,258k	_2,418,773k	_{p=0.889 n=20}
_{Memory Allocs}	_{37,191,136 (± 0.13%)}	_{37,170,381 (± 0.08%)}	_~	_37,079,212	_37,279,659	_{p=0.925 n=20}
_{Config Time}	_{0.003s (± 6.00%)}	_{0.003s (± 3.54%)}	_~	_0.002s	_0.003s	_{p=0.605 n=20}
_{Parse Time}	_{0.246s (± 2.26%)}	_{0.245s (± 2.50%)}	_~	_0.222s	_0.277s	_{p=0.723 n=20}
_{Bind Time}	_{0.087s (± 9.95%)}	_{0.092s (±12.40%)}	_~	_0.070s	_0.133s	_{p=0.867 n=20}
_{Check Time}	_{5.706s (± 0.34%)}	_{5.726s (± 1.50%)}	_~	_5.633s	_6.492s	_{p=0.262 n=20}
_{Emit Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=20}
_{Total Time}	_{6.054s (± 0.37%)}	_{6.076s (± 1.43%)}	_~	_5.977s	_6.847s	_{p=0.344 n=20}
_{tanstack-router - native}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=20}
_Symbols	_571,756	_571,756	_~	_~	_~	_{p=1.000 n=20}
_Types	_397,689	_397,689	_~	_~	_~	_{p=1.000 n=20}
_{Memory Used}	_{326,437k (± 0.02%)}	_{326,444k (± 0.02%)}	_~	_326,125k	_326,721k	_{p=0.952 n=20}
_{Memory Allocs}	_{4,338,525 (± 0.16%)}	_{4,334,179 (± 0.14%)}	_~	_4,319,061	_4,363,557	_{p=0.277 n=20}
_{Config Time}	_0.001s	_0.001s	_~	_~	_~	_{p=1.000 n=20}
_{Parse Time}	_{0.039s (± 3.59%)}	_{0.041s (± 4.86%)}	_~	_0.034s	_0.050s	_{p=0.192 n=20}
_{Bind Time}	_{0.014s (±11.26%)}	_{0.014s (±10.00%)}	_~	_0.011s	_0.021s	_{p=0.701 n=20}
_{Check Time}	_{0.516s (± 3.10%)}	_{0.506s (± 0.84%)}	_~	_0.487s	_0.530s	_{p=0.213 n=20}
_{Emit Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=20}
_{Total Time}	_{0.588s (± 3.14%)}	_{0.579s (± 0.86%)}	_~	_0.564s	_0.606s	_{p=0.498 n=20}
_{ts-pre-modules - native}
_Errors	₈₇	₈₇	_~	_~	_~	_{p=1.000 n=20}
_Symbols	_231,616	_231,616	_~	_~	_~	_{p=1.000 n=20}
_Types	_181,195	_181,195	_~	_~	_~	_{p=1.000 n=20}
_{Memory Used}	_{192,973k (± 0.02%)}	_{192,989k (± 0.02%)}	_~	_192,855k	_193,115k	_{p=0.588 n=20}
_{Memory Allocs}	_{1,310,148 (± 0.02%)}	_{1,310,335 (± 0.02%)}	_~	_1,309,512	_1,311,797	_{p=0.301 n=20}
_{Config Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=20}
_{Parse Time}	_{0.041s (± 4.26%)}	_{0.043s (± 5.78%)}	_~	_0.039s	_0.063s	_{p=0.429 n=20}
_{Bind Time}	_{0.020s (± 5.48%)}	_{0.020s (± 6.15%)}	_~	_0.016s	_0.026s	_{p=0.962 n=20}
_{Check Time}	_{0.295s (± 1.01%)}	_{0.298s (± 2.50%)}	_~	_0.282s	_0.357s	_{p=0.973 n=20}
_{Emit Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=20}
_{Total Time}	_{0.363s (± 0.81%)}	_{0.367s (± 2.74%)}	_~	_0.352s	_0.454s	_{p=0.825 n=20}
_{vscode - native}
_Errors	₁₁	₁₁	_~	_~	_~	_{p=1.000 n=20}
_Symbols	_7,563,659	_7,563,659	_~	_~	_~	_{p=1.000 n=20}
_Types	_4,408,914	_4,408,914	_~	_~	_~	_{p=1.000 n=20}
_{Memory Used}	_{5,226,984k (± 0.01%)}	_{5,227,270k (± 0.01%)}	_~	_5,224,709k	_5,229,833k	_{p=0.583 n=20}
_{Memory Allocs}	_{57,312,771 (± 0.02%)}	_{57,312,190 (± 0.01%)}	_~	_57,298,591	_57,362,948	_{p=0.925 n=20}
_{Config Time}	_{0.033s (± 0.72%)}	_{0.033s (± 0.73%)}	_~	_0.033s	_0.035s	_{p=0.369 n=20}
_{Parse Time}	_{0.885s (± 0.77%)}	_{0.887s (± 1.03%)}	_~	_0.856s	_0.933s	_{p=0.784 n=20}
_{Bind Time}	_{0.285s (± 0.80%)}	_{0.292s (± 2.19%)}	_{+0.006s (+ 2.17%)}	_0.279s	_0.345s	_{p=0.040 n=20}
_{Check Time}	_{7.253s (± 0.30%)}	_{7.237s (± 0.37%)}	_~	_7.071s	_7.353s	_{p=0.533 n=20}
_{Emit Time}	_{1.886s (± 1.81%)}	_{1.905s (± 4.46%)}	_~	_1.840s	_2.652s	_{p=0.202 n=20}
_{Total Time}	_{10.399s (± 0.34%)}	_{10.412s (± 0.65%)}	_~	_10.297s	_10.982s	_{p=0.703 n=20}
_{webpack - native}
_Errors	₅₉₅	₅₉₅	_~	_~	_~	_{p=1.000 n=20}
_Symbols	_861,433	_861,433	_~	_~	_~	_{p=1.000 n=20}
_Types	_595,020	_595,020	_~	_~	_~	_{p=1.000 n=20}
_{Memory Used}	_{632,957k (± 0.01%)}	_{632,910k (± 0.01%)}	_~	_632,413k	_633,251k	_{p=0.445 n=20}
_{Memory Allocs}	_{5,884,100 (± 0.05%)}	_{5,887,181 (± 0.06%)}	_~	_5,878,917	_5,906,655	_{p=0.253 n=20}
_{Config Time}	_0.004s	_0.004s	_~	_~	_~	_{p=1.000 n=20}
_{Parse Time}	_{0.117s (± 1.76%)}	_{0.116s (± 2.23%)}	_~	_0.106s	_0.132s	_{p=0.302 n=20}
_{Bind Time}	_{0.037s (± 6.86%)}	_{0.038s (± 8.44%)}	_~	_0.032s	_0.056s	_{p=0.501 n=20}
_{Check Time}	_{0.934s (± 1.23%)}	_{0.939s (± 1.35%)}	_~	_0.905s	_1.013s	_{p=0.733 n=20}
_{Emit Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=20}
_{Total Time}	_{1.113s (± 1.06%)}	_{1.118s (± 1.24%)}	_~	_1.090s	_1.203s	_{p=0.673 n=20}
_{xstate-main - native}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=20}
_Symbols	_640,490	_640,490	_~	_~	_~	_{p=1.000 n=20}
_Types	_387,984	_387,984	_~	_~	_~	_{p=1.000 n=20}
_{Memory Used}	_{350,077k (± 0.03%)}	_{350,035k (± 0.02%)}	_~	_349,841k	_350,363k	_{p=0.974 n=20}
_{Memory Allocs}	_{3,970,304 (± 0.10%)}	_{3,968,956 (± 0.09%)}	_~	_3,955,089	_3,982,011	_{p=0.738 n=20}
_{Config Time}	_0.001s	_0.001s	_~	_~	_~	_{p=1.000 n=20}
_{Parse Time}	_{0.061s (± 3.84%)}	_{0.061s (± 2.70%)}	_~	_0.055s	_0.068s	_{p=1.000 n=20}
_{Bind Time}	_{0.021s (±11.52%)}	_{0.020s (±11.96%)}	_~	_0.016s	_0.032s	_{p=0.552 n=20}
_{Check Time}	_{0.388s (± 1.01%)}	_{0.392s (± 1.02%)}	_~	_0.382s	_0.417s	_{p=0.103 n=20}
_{Emit Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=20}
_{Total Time}	_{0.475s (± 1.27%)}	_{0.479s (± 1.08%)}	_~	_0.461s	_0.504s	_{p=0.524 n=20}

System info unknown

Hosts

native

Scenarios

Compiler-Unions - native
angular-1 - native
arktype - native
class-transformer - native
effect - native
mui-docs - native
sentry - native
social-app - native
strada-build-src - native
strada-compiler - native
t3code-server - native
tanstack-router - native
ts-pre-modules - native
vscode - native
webpack - native
xstate-main - native

_Benchmark	_Name	_Iterations
_Current	_pr	₂₀
_Baseline	_baseline	₂₀

Developer Information:

Download Benchmarks

Jake Bailey (jakebailey) requested review from Andrew Branch (andrewbranch) and a balanced review from Copilot October 31, 2026 06:15

github-project-automation Bot added this to PR Backlog Oct 31, 2026

typescript-automation Bot assigned Jake Bailey (jakebailey) Oct 31, 2026

github-project-automation Bot moved this to Not started in PR Backlog Oct 31, 2026

typescript-automation Bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Oct 31, 2026

Copilot started reviewing on behalf of Jake Bailey (jakebailey) October 31, 2026 06:16

View session

Copilot AI reviewed Oct 31, 2026

View reviewed changes

Comment thread tsc/internal/parser/parser.go Resolved

Comment thread tsc/internal/parser/reparser.go Resolved

Jake Bailey (jakebailey) force-pushed the cjs-indicator branch from 0a43778 to fce61e8 Compare October 31, 2026 12:30

Jake Bailey (jakebailey) requested a balanced review from Copilot October 31, 2026 12:30

Copilot started reviewing on behalf of Jake Bailey (jakebailey) October 31, 2026 12:31

View session

Copilot AI reviewed Oct 31, 2026

View reviewed changes

Jake Bailey (jakebailey) added 2 commits October 31, 2026 13:23

Avoid reflowing Binder struct fields

7dced36

Navigation Menu

Repository navigation

Compute CommonJSModuleIndicator in the parser - #65073

Compute CommonJSModuleIndicator in the parser#65073
Jake Bailey (jakebailey) wants to merge 3 commits into
microsoft:mainfrom
jakebailey:cjs-indicator

Jake Bailey (jakebailey) commented Oct 31, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Jake Bailey (jakebailey) commented Oct 31, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Jake Bailey (jakebailey) commented Oct 31, 2026

Uh oh!

typescript-automation Bot commented Oct 31, 2026 •

edited

Loading

Uh oh!

typescript-automation Bot commented Oct 31, 2026

tsc

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Jake Bailey (jakebailey) commented Oct 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Jake Bailey (jakebailey) commented Oct 31, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Jake Bailey (jakebailey) commented Oct 31, 2026

Uh oh!

typescript-automation Bot commented Oct 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-automation Bot commented Oct 31, 2026

tsc

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Jake Bailey (jakebailey) commented Oct 31, 2026 •

edited

Loading

typescript-automation Bot commented Oct 31, 2026 •

edited

Loading