[legendecas]

This ensures that the src/lib changes (like emitting trace events) are compatible with perfetto, and compatible with V8 compiled with perfetto.

Refs: #64565
Fixes: nodejs/diagnostics#654

[nodejs-github-bot]

Review requested:

• @nodejs/actions

[avivkeller]

Suggested change

	path: node
	- name: Install Clang ${{ env.CLANG_VERSION }}
	uses: ./node/.github/actions/install-clang
	with:
	clang-version: ${{ env.CLANG_VERSION }}
	- name: Install Clang ${{ env.CLANG_VERSION }}
	uses: .github/actions/install-clang
	with:
	clang-version: ${{ env.CLANG_VERSION }}

nit: use the CWD

[legendecas]

I replicated this from https://github.com/nodejs/node/blob/main/.github/workflows/test-linux-quic.yml. Maybe it was replicated from https://github.com/nodejs/node/blob/main/.github/workflows/test-linux.yml

[avivkeller]

LGTM, we should probably update the other workflows to use the CWD, IMO it's cleaner

[Renegade334]

Could we enable this for the existing Linux workflow rather than adding an additional run?

[legendecas]

Could we enable this for the existing Linux workflow rather than adding an additional run?

We could. Still, I think in the near future, we might want to keep testing both legacy tracing and perfetto tracing, until we can fully deprecate the legacy one.

[aduh95]

For other flags (except QUIC, but the QUIC job being restricted to a very limited set of files, that's less of a concern), we put this as part of the test-shared workflow. Can we do that here as well? Having a dedicated job is probably a waste and won't scale well.

[legendecas]

Thanks for the suggestion, updated!

[codecov]

Codecov Report

❌ Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.17%. Comparing base (f8f8aa2) to head (a8e5815).
⚠️ Report is 51 commits behind head on main.

Files with missing lines	Patch %	Lines
src/tracing/trace_event_helper.cc	92.30%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #64721      +/-   ##
==========================================
+ Coverage   90.14%   90.17%   +0.03%     
==========================================
  Files         746      746              
  Lines      242818   242771      -47     
  Branches    45765    45740      -25     
==========================================
+ Hits       218884   218918      +34     
+ Misses      15417    15345      -72     
+ Partials     8517     8508       -9     

Files with missing lines	Coverage Δ
src/debug_utils.h	80.00% <ø> (ø)
src/node_trace_events.cc	82.30% <ø> (ø)
src/tracing/node_trace_writer.cc	77.50% <100.00%> (-1.12%)	⬇️
src/tracing/trace_event_helper.h	100.00% <ø> (ø)
src/tracing/trace_event_helper.cc	95.65% <92.30%> (-4.35%)	⬇️

... and 60 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[legendecas]

Rebased on the latest main branch to fix conflicts and build failures.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/75312/