[Ocramius]

This change ensures that, when converting a StreamedResponse to output within php-runtime/swoole,
the output is streamed chunk-by-chunk, instead of being buffered in its entirety, and then being
sent out to the swooler server all in one shot.

This should fix some obvious performance, latency and memory issues related to streaming common responses
assembled by PHP-side processes.

Note: you will still need to disable symfony's StreamedResponseListener when working with this package.

Fixes #115

[Ocramius]

The last deprecation that seems to make CI fail is caused by Symfony\Component\HttpFoundation#get() being called by Illuminate\Http\Request due to inheritance.

Because the parent class != child class, this code leads to a deprecation error:

        if (!$dup->get('_format') && $this->get('_format')) {
            $dup->attributes->set('_format', $this->get('_format'));
        }

Overall, that's not fixable in this library.

EDIT: suggestion: disable symfony's deprecation system, and just use phpunit/phpunit, which would've saved ~1h of work on my end :P

[alexander-schranz]

Changes looks fine from my point of view. But I'm not familiar enough with the error_handler. But it seems only effecting phpunit tests not application itself?

The tests deprecations which are thrown in the CI were also before there so not related to your PR changes.

[Ocramius]

But it seems only effecting phpunit tests not application itself?

Yes, that's because of the runner modifying global state in an unclean way. TBH, reminds me that I have to disable that error handler for my own use-cases as well :)

[Ocramius]

Going to release this on a fork meanwhile, to allow for local usage on my end.

[Ocramius]

@alexander-schranz I see this is approved - anything else to be done to get it through, to a release?

[alexander-schranz]

@Ocramius Sorry for the delay. Did work all like expected, Thank you for the pull request.
From my side there is nothing which is against about releasing this. /cc @Nyholm

[Ocramius]

Thanks @alexander-schranz!

[Ocramius]

Is some automation needed to cut 0.3.1 or such? Looking at https://github.com/php-runtime/swoole/releases

[alexander-schranz]

@Ocramius Was missing some permissions. Now 0.3.1 is tagged!

[Ocramius]

Awesome, thanks!