You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Default CSS for glyphicons produces conflict with bootstrap5 components (with potential solution) #1820
Describe the bug
Manually adding a bootstrap5 modal to the html body results in wrong position of the modal (see screenshots at the end).
To Reproduce
importfoliummy_map=folium.Map()
# Adding modal from https://www.w3schools.com/bootstrap5/bootstrap_modal.phpmy_map.get_root().html.add_child(folium.Element("""<!-- Button to Open the Modal --><button type="button" class="btn btn-primary" data-bs-toggle="modal" data-bs-target="#myModal"> Open modal</button><!-- The Modal --><div class="modal" id="myModal"> <div class="modal-dialog"> <div class="modal-content"> <!-- Modal Header --> <div class="modal-header"> <h4 class="modal-title">Modal Heading</h4> <button type="button" class="btn-close" data-bs-dismiss="modal"></button> </div> <!-- Modal body --> <div class="modal-body"> Modal body.. </div> <!-- Modal footer --> <div class="modal-footer"> <button type="button" class="btn btn-danger" data-bs-dismiss="modal">Close</button> </div> </div> </div></div>"""))
my_map.save(outfile="map.html")
Expected behavior
The modal should appear in the same way as in the bootstrap5 modal example on w3schools.
Environment:
OS: macOS 14.0
Browser: Firefox 118.0.1
Python version: 3.10.7
folium version: 0.14.0
branca version: 0.6.0
Plain .py, no Jupyter Notebook
Possible solutions
This issue is resolved when uncommenting the stylesheet on netdna for bootstrap 3.0.0, however, I cannot tell what the implications to other functions of folium that would have (e.g. glyphicons).
This still reproduces on main, and I think the root cause is narrower than it first looks — worth writing down before anyone fixes it.
The migration to Bootstrap 5 removed the worst of the old conflict (folium no longer loads the full Bootstrap 3 bootstrap.min.css). But one Bootstrap 3 stylesheet is still injected into every map, in folium/folium.py:
# glyphicons came from Bootstrap 3 and are used for Awesome Markers
(
"glyphicons_css",
"https://netdna.bootstrapcdn.com/bootstrap/3.0.0/css/bootstrap-glyphicons.css",
),
Despite the name, that file is not glyphicons-only — it's a full Bootstrap 3 base stylesheet. Alongside the @font-face/.glyphicon* rules it also ships a normalize reset and global element styles, including:
It's linked after the Bootstrap 5 CSS, so those body rules (and the reset) win over BS5's Reboot for anything the user adds to the page — which is exactly the modal/layout shift in the screenshots above.
folium only actually needs the @font-face + .glyphicon* rules from that file (for Icon(prefix="glyphicon", ...) / Awesome Markers). So the fix I'd propose is to stop pulling the whole BS3 base and instead ship a minimal glyphicons-only stylesheet — just the font-face and .glyphicon classes, with an absolute font URL — the same way leaflet.awesome.rotate.min.css is already vendored under folium/templates/. That keeps glyphicon markers working while removing the global body/reset pollution.
Before I open a PR: does that direction sound right to you, or would you rather drop the Bootstrap-3 glyphicon dependency entirely (Awesome Markers can use Font Awesome, which folium already loads)? Happy to implement whichever you prefer.
Both would be fine with me. Your first proposed approach sounds like less work than totally dropping the Bootstrap-3 glyphicon dependency. Would the second approach also entail a customer facing change?
Thanks @hansthen! Yes — the second approach (dropping the Bootstrap-3 glyphicon dependency in favour of Font Awesome) would be customer-facing: anyone using folium.Icon(prefix="glyphicon", icon=...) relies on the Glyphicons Halflings font that this CSS provides, so removing it would break their existing markers.
The first approach avoids that entirely — a vendored glyphicons-only stylesheet keeps prefix="glyphicon" working exactly as it does today and only drops the unintended body/normalize/reset rules that are leaking onto the page. So it's not a customer-facing change; the only visible difference is that folium stops overriding the host page's body styles.
Activity
adarshsm commentedon Jul 30, 2026
This still reproduces on
main, and I think the root cause is narrower than it first looks — worth writing down before anyone fixes it.The migration to Bootstrap 5 removed the worst of the old conflict (folium no longer loads the full Bootstrap 3
bootstrap.min.css). But one Bootstrap 3 stylesheet is still injected into every map, infolium/folium.py:Despite the name, that file is not glyphicons-only — it's a full Bootstrap 3 base stylesheet. Alongside the
@font-face/.glyphicon*rules it also ships a normalize reset and global element styles, including:It's linked after the Bootstrap 5 CSS, so those
bodyrules (and the reset) win over BS5's Reboot for anything the user adds to the page — which is exactly the modal/layout shift in the screenshots above.folium only actually needs the
@font-face+.glyphicon*rules from that file (forIcon(prefix="glyphicon", ...)/ Awesome Markers). So the fix I'd propose is to stop pulling the whole BS3 base and instead ship a minimal glyphicons-only stylesheet — just the font-face and.glyphiconclasses, with an absolute font URL — the same wayleaflet.awesome.rotate.min.cssis already vendored underfolium/templates/. That keeps glyphicon markers working while removing the globalbody/reset pollution.Before I open a PR: does that direction sound right to you, or would you rather drop the Bootstrap-3 glyphicon dependency entirely (Awesome Markers can use Font Awesome, which folium already loads)? Happy to implement whichever you prefer.
hansthen commentedon Jul 31, 2026
Both would be fine with me. Your first proposed approach sounds like less work than totally dropping the Bootstrap-3 glyphicon dependency. Would the second approach also entail a customer facing change?
adarshsm commentedon Jul 31, 2026
Thanks @hansthen! Yes — the second approach (dropping the Bootstrap-3 glyphicon dependency in favour of Font Awesome) would be customer-facing: anyone using
folium.Icon(prefix="glyphicon", icon=...)relies on the Glyphicons Halflings font that this CSS provides, so removing it would break their existing markers.The first approach avoids that entirely — a vendored glyphicons-only stylesheet keeps
prefix="glyphicon"working exactly as it does today and only drops the unintendedbody/normalize/reset rules that are leaking onto the page. So it's not a customer-facing change; the only visible difference is that folium stops overriding the host page'sbodystyles.I'll go with the first approach and open a PR.
Inline glyphicons stylesheet instead of linking a not-yet-published C…
Vendor a glyphicons-only stylesheet instead of the full Bootstrap 3 b…