Skip to content

gh-160976: Preserve source file path in Gecko sampling collector - #160982

Open
makwana-akshat wants to merge 2 commits into
python:mainfrom
makwana-akshat:gh-160976-gecko-filename-path
Open

makwana-akshat wants to merge 2 commits into
python:mainfrom
makwana-akshat:gh-160976-gecko-filename-path

Conversation

@makwana-akshat

@makwana-akshat makwana-akshat commented Oct 30, 2026 •

Copy link
Copy Markdown

Fixes #160976.

Summary

The Gecko sampling profiler exporter used only the basename of Python source filenames, losing directory information when different files shared the same basename.

This PR:

  • Preserves the full source filename path in the Gecko function table.
  • Adds a regression test verifying that files with identical basenames in different directories retain distinct paths.
  • Adds a NEWS entry documenting the fix.

@python-cla-bot

python-cla-bot Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@maurycy

maurycy commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

cc @ivonastojanovic ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

profiling.sampling (Tachyon) gecko output: Only source file basename is shown

2 participants

⌂ Proxy