Skip to content

gh-145805: Change EMSDK_CACHE to PY_EMSDK_CACHE #160989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hoodmane wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-145805: Change EMSDK_CACHE to PY_EMSDK_CACHE #160989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26c44be
gh-145805: Change EMSDK_CACHE to PY_EMSDK_CACHE
hoodmane Oct 30, 2026
8edfd23
Update github action
hoodmane Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/reusable-emscripten.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
f.write(f"node-version={config['node-version']}\n")
f.write(f"deps-hash={h.hexdigest()}\n")
with open(os.environ["GITHUB_ENV"], "a") as f:
f.write(f"EMSDK_CACHE={emsdk_cache}\n")
f.write(f"PY_EMSDK_CACHE={emsdk_cache}\n")
- name: "Install Node.js"
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
Expand All @@ -48,7 +48,7 @@ jobs:
id: emsdk-cache
uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
with:
path: ${{ env.EMSDK_CACHE }}
path: ${{ env.PY_EMSDK_CACHE }}
key: emsdk-${{ steps.emscripten-config.outputs.emscripten-version }}-${{ steps.emscripten-config.outputs.deps-hash }}
restore-keys: emsdk-${{ steps.emscripten-config.outputs.emscripten-version }}
- name: "Install Python"
Expand Down
4 changes: 2 additions & 2 deletions Platforms/emscripten/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -812,12 +812,12 @@ def main():
subcommand.add_argument(
"--emsdk-cache",
action="store",
default=os.environ.get("EMSDK_CACHE"),
default=os.environ.get("PY_EMSDK_CACHE"),
dest="emsdk_cache",
help=(
"Path to emsdk cache directory. If provided, validates that "
"the required emscripten version is installed. "
"Can also be set with the EMSDK_CACHE environment variable."
"Can also be set with the PY_EMSDK_CACHE environment variable."
),
)

Expand Down
Loading
⌂ Proxy