Repository navigation
Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22326.
An imported placeholder can be the receiver of a dynamic-class factory while semantic analysis is still resolving an import cycle. Preserve its qualified name on the
NameExprso the factory's plugin hook can run. Without it, the generated base is rejected as a variable and inherited methods becomeAny.The production change is one line in
SemanticAnalyzer.bind_name_expr. The regression extends the existingfrom_querysettest plugin to defer incomplete classes, publish a placeholder, and reuse the resolved class on later passes. It checks both inherited method types and rejection of a missing method, without Django or a third-party plugin dependency.Validation against master
7da2058491422897ecdbf61261d2540bb10099a0on Python 3.14.6:python -m pytest -n2 mypy/test/testcheck.py::TypeCheckSuite::check-custom-plugin.test --tb=short -q: 65 passed.git diff --checkpass for the changed code.Prepared with AI assistance from a downstream manager-typing failure. No downstream package or release configuration is included.