Repository navigation
Conversation
CommandProcessor#unlink called IO.unlink for non-directory paths, but IO has no unlink method, so removing a file raised NoMethodError. Call File.unlink instead, and correct the doc comment that pointed to IO.unlink. Add tests for unlinking a file and a directory. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shell::CommandProcessor#unlinkcallsIO.unlinkwhen the path is not a directory.But no such method exists, so
sh.unlink("some_file")raises:Shell#unlinkremoves directories correctly.Changes
File.unlinkfor non-directory paths.IO.unlink.unlinkon a file and on a directory.