Skip to content

[Bug Fix] Fix variable reference as key error in distributed shampoo - #299

Open
c0derzer0 wants to merge 1 commit into
tensorflow:masterfrom
c0derzer0:bugfix/fix_distributed_shampoo_failing_with_vref_error
Open

c0derzer0 wants to merge 1 commit into
tensorflow:masterfrom
c0derzer0:bugfix/fix_distributed_shampoo_failing_with_vref_error

Conversation

@c0derzer0

Copy link
Copy Markdown

This PR addresses the issue #285

While applying gradients with distributed shampoo, it fails with the error "TypeError: Variable is unhashable. Instead, use variable.ref() as the key".

This is caused because of using variable instead of variable.ref() as key which is fixed in this pull request. This has been a recurring issue whenever the lingvo library is reinstalled and it needs to be changed locally. This PR will also address this issue for any other users trying to use distributed shampoo.

While applying gradients with distributed shampoo, it fails with the error
"TypeError: Variable is unhashable. Instead, use variable.ref() as the key".
This is caused because of using variable instead of variable.ref() as key
which is fixed in this commit
@google-cla

google-cla Bot commented Oct 7, 2022

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

⌂ Proxy