Repository navigation
fix(client): preserve terminal watch outcomes - #991
Open
Tmwakalasya wants to merge 1 commit into
Open
Tmwakalasya wants to merge 1 commit into
Tmwakalasya wants to merge 1 commit into
Conversation
Tmwakalasya
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
October 29, 2026 20:44
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
An active watch can keep polling after a request has finished. For example, the gateway can record a late
cancellingintent afterlanded; the materialized summary retains the terminal outcome, but the client currently uses the latest history status and leaves the row unsettled. A background event after anerrorstatus can also erase or replace the terminal failure explanation.What?
Track the current outcome while digesting history. Once a terminal status is present, later nonterminal entries no longer replace its status or diagnostic. Preserve the chronological trail, including late intents and background events, and continue accepting updated terminal entries.
This addresses terminal-to-nonterminal regression in the history-based watch. It does not add request-version ordering between conflicting terminal records; the history wire type does not carry that version.
Test Plan
landed,cancelled, anderrorfollowed bycancellingleft the tracker unsettled; later events lost the terminal diagnostic../tool/bazel test //submitqueue/client:go_default_test --test_output=errorspassed../tool/bazel test //submitqueue/client:go_default_test --@rules_go//go/config:race --test_output=errorspassed.make fmt,make lint,make check-tidy, andmake check-gazellepassed.The tests exercise history digestion and tracker completion locally. The full integration/e2e suites were not run.
Issue
No linked issue.