Skip to content

fix: keep queue connection retry delay above job timeouts - #1308

Draft
outdooracorn wants to merge 2 commits into
mainfrom
ollie-fix-retry_after-timeout
Draft

outdooracorn wants to merge 2 commits into
mainfrom
ollie-fix-retry_after-timeout

Conversation

@outdooracorn

Copy link
Copy Markdown
Member

Bug: T441697

@outdooracorn outdooracorn self-assigned this Oct 19, 2026
@outdooracorn

outdooracorn commented Oct 19, 2026 •

Copy link
Copy Markdown
Member Author

This is still a draft PR as is I'm not 100% sure on the current and desired behaviour (see #1290 (comment)).

This PR was meant to be part of stack #1291 before that got merged early (apparently you can't add to a stack that has all PRs merged 😕).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Horizon’s timeout guidance says Horizon’s timeout should exceed job-level timeouts. I think an assertion that Horizon’s timeout is greater than every job-level timeout is a good addition

];

$this->assertIsInt($retryAfter);
$this->assertNotEmpty($timeouts);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So $timeouts is a combined list of timeouts from application jobs, Horizon config and worker. Does that mean that assertNotEmpty($timeouts) only proves at least one of them provides a timeout? Should we instead assert them one by one and then combine/merge them together as a big $timeouts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ Proxy