Repository navigation
fix: keep queue connection retry delay above job timeouts - #1308
outdooracorn wants to merge 2 commits into
Conversation
|
This is still a draft PR as is I'm not 100% sure on the current and desired behaviour (see #1290 (comment)). This PR was meant to be part of stack #1291 before that got merged early (apparently you can't add to a stack that has all PRs merged 😕). |
There was a problem hiding this comment.
Horizon’s timeout guidance says Horizon’s timeout should exceed job-level timeouts. I think an assertion that Horizon’s timeout is greater than every job-level timeout is a good addition
| ]; | ||
|
|
||
| $this->assertIsInt($retryAfter); | ||
| $this->assertNotEmpty($timeouts); |
There was a problem hiding this comment.
So $timeouts is a combined list of timeouts from application jobs, Horizon config and worker. Does that mean that assertNotEmpty($timeouts) only proves at least one of them provides a timeout? Should we instead assert them one by one and then combine/merge them together as a big $timeouts
Bug: T441697