Skip to content

Add metrics: monthly casual users and active users - #936

Merged
rosalieper merged 5 commits into
mainfrom
api-T391464
May 27, 2025
Merged

rosalieper merged 5 commits into
mainfrom
api-T391464

Conversation

@rosalieper

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread app/WikiDailyMetrics.php
'quarterly_actions',
'number_of_triples',
'monthly_casual_users',
'monthly_active_users',

@tarrow tarrow May 22, 2025 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs to be added to the metricNames list or the comparison for seeing if we need to add new a new record won't work

@tarrow

tarrow commented May 22, 2025

Copy link
Copy Markdown
Contributor

Mostly looks fine to me; as I mentioned yesterday let's get together and have another stab at adding some tests for this stuff because right now we don't which is a little unpleasant and makes touching these areas slower (we always need to manually test them.

@deer-wmde

Copy link
Copy Markdown
Contributor

I added the metric names in the static array, added bits to the migration code and tested the query on staging; If you don't see anything else I think this is ready for staging @tarrow

@deer-wmde

Copy link
Copy Markdown
Contributor

@rosalieper and I looked at this together and I stick the approve on it (even though the last changes were from me but we reviewd it)

@rosalieper
rosalieper merged commit 9a7377c into main May 27, 2025
@rosalieper
rosalieper deleted the api-T391464 branch May 27, 2025 10:25
deer-wmde added a commit that referenced this pull request Dec 15, 2025
* add DB migration

* Add metrics monthly casual users and active users

* add new metrics to WikiDailyMetrics::$metricNames as well

* fix migration reversal code

* update changelog

---------

Co-authored-by: dena <dena@wikimedia.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ Proxy